Prevent pubsub managers from ever crashing

Fixes #1262

src/socketio/async_pubsub_manager.py

@@ -230,11 +230,13 @@ class AsyncPubSubManager(AsyncManager):
                                     await self._handle_close_room(data)
                         except asyncio.CancelledError:
                             raise  # let the outer try/except handle it
-                        except:
+                        except Exception:
                             self.server.logger.exception(
-                                'Unknown error in pubsub listening task')
+                                'Handler error in pubsub listening thread')
+                self.server.logger.error('pubsub listen() exited unexpectedly')
+                break  # loop should never exit except in unit tests!
             except asyncio.CancelledError:  # pragma: no cover
                 break
-            except:  # pragma: no cover
+            except Exception:  # pragma: no cover
-                import traceback
+                self.server.logger.exception('Unexpected Error in pubsub '
-                traceback.print_exc()
+                                             'listening thread')

src/socketio/pubsub_manager.py

@@ -188,6 +188,8 @@ class PubSubManager(Manager):
                            namespace=message.get('namespace'))
 
     def _thread(self):
+        while True:
+            try:
                 for message in self._listen():
                     data = None
                     if isinstance(message, dict):
@@ -220,6 +222,11 @@ class PubSubManager(Manager):
                                     self._handle_leave_room(data)
                                 elif data['method'] == 'close_room':
                                     self._handle_close_room(data)
-                except:
+                        except Exception:
                             self.server.logger.exception(
-                        'Unknown error in pubsub listening thread')
+                                'Handler error in pubsub listening thread')
+                self.server.logger.error('pubsub listen() exited unexpectedly')
+                break  # loop should never exit except in unit tests!
+            except Exception:  # pragma: no cover
+                self.server.logger.exception('Unexpected Error in pubsub '
+                                             'listening thread')

tests/async/test_pubsub_manager.py

@@ -541,7 +541,6 @@ class TestAsyncPubSubManager(unittest.TestCase):
                    'host_id': host_id}
             yield pickle.dumps({'method': 'close_room', 'value': 'baz',
                                 'host_id': host_id})
-            raise asyncio.CancelledError()  # force the thread to exit
 
         self.pm._listen = messages
         _run(self.pm._thread())