Browse Source

fixes from code review

pull/627/head
Dan Ditomaso 1 year ago
parent
commit
a7ffb8d8fc
  1. 2
      .github/workflows/update-stable-from-master.yml
  2. 3
      deno.json
  3. 7
      deno.lock
  4. 8
      src/components/DeviceInfoPanel.tsx
  5. 2
      vite.config.ts

2
.github/workflows/update-stable-from-master.yml

@ -9,7 +9,7 @@ permissions:
jobs: jobs:
update-stable-branch: update-stable-branch:
name: Update Stable Branch fromMain name: Update Stable Branch from Main
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:

3
deno.json

@ -4,7 +4,8 @@
"@pages/": "./src/pages/", "@pages/": "./src/pages/",
"@components/": "./src/components/", "@components/": "./src/components/",
"@core/": "./src/core/", "@core/": "./src/core/",
"@layouts/": "./src/layouts/" "@layouts/": "./src/layouts/",
"@std/path": "jsr:@std/path@^1.1.0"
}, },
"compilerOptions": { "compilerOptions": {
"lib": [ "lib": [

7
deno.lock

@ -2,6 +2,7 @@
"version": "5", "version": "5",
"specifiers": { "specifiers": {
"jsr:@std/path@*": "1.0.6", "jsr:@std/path@*": "1.0.6",
"jsr:@std/path@^1.1.0": "1.1.0",
"npm:@bufbuild/protobuf@^2.2.5": "2.2.5", "npm:@bufbuild/protobuf@^2.2.5": "2.2.5",
"npm:@jsr/[email protected]": "2.6.2", "npm:@jsr/[email protected]": "2.6.2",
"npm:@jsr/[email protected]": "2.6.0-0", "npm:@jsr/[email protected]": "2.6.0-0",
@ -83,6 +84,9 @@
"jsr": { "jsr": {
"@std/[email protected]": { "@std/[email protected]": {
"integrity": "ab2c55f902b380cf28e0eec501b4906e4c1960d13f00e11cfbcd21de15f18fed" "integrity": "ab2c55f902b380cf28e0eec501b4906e4c1960d13f00e11cfbcd21de15f18fed"
},
"@std/[email protected]": {
"integrity": "ddc94f8e3c275627281cbc23341df6b8bcc874d70374f75fec2533521e3d6886"
} }
}, },
"npm": { "npm": {
@ -7294,6 +7298,9 @@
} }
}, },
"workspace": { "workspace": {
"dependencies": [
"jsr:@std/path@^1.1.0"
],
"packageJson": { "packageJson": {
"dependencies": [ "dependencies": [
"npm:@bufbuild/protobuf@^2.2.5", "npm:@bufbuild/protobuf@^2.2.5",

8
src/components/DeviceInfoPanel.tsx

@ -13,7 +13,7 @@ import { Subtle } from "./UI/Typography/Subtle.tsx";
import { Avatar } from "./UI/Avatar.tsx"; import { Avatar } from "./UI/Avatar.tsx";
import { DeviceMetrics } from "./types.ts"; import { DeviceMetrics } from "./types.ts";
import { Button } from "./UI/Button.tsx"; import { Button } from "./UI/Button.tsx";
import React from "react"; import React, { Fragment } from "react";
import { useTranslation } from "react-i18next"; import { useTranslation } from "react-i18next";
import ThemeSwitcher from "./ThemeSwitcher.tsx"; import ThemeSwitcher from "./ThemeSwitcher.tsx";
import LanguageSwitcher from "./LanguageSwitcher.tsx"; import LanguageSwitcher from "./LanguageSwitcher.tsx";
@ -188,7 +188,11 @@ export const DeviceInfoPanel = ({
{actionButtons.map((buttonItem) => { {actionButtons.map((buttonItem) => {
const Icon = buttonItem.icon; const Icon = buttonItem.icon;
if (buttonItem.render) { if (buttonItem.render) {
return buttonItem.render(); return (
<Fragment key={buttonItem.id}>
{buttonItem.render()}
</Fragment>
);
} }
return ( return (
<Button <Button

2
vite.config.ts

@ -1,7 +1,7 @@
import { defineConfig } from "vite"; import { defineConfig } from "vite";
import react from "@vitejs/plugin-react"; import react from "@vitejs/plugin-react";
import { VitePWA } from "vite-plugin-pwa"; import { VitePWA } from "vite-plugin-pwa";
import { resolve } from "jsr:@std/path/resolve"; import { resolve } from "@std/path/resolve";
let hash = ""; let hash = "";
try { try {

Loading…
Cancel
Save