Browse Source

Handle undefined node better

pull/618/head
philon- 1 year ago
parent
commit
847f19790b
  1. 5
      src/core/hooks/useFavoriteNode.test.ts
  2. 5
      src/core/hooks/useFavoriteNode.ts
  3. 5
      src/core/hooks/useIgnoreNode.test.ts
  4. 5
      src/core/hooks/useIgnoreNode.ts

5
src/core/hooks/useFavoriteNode.test.ts

@ -87,8 +87,7 @@ describe("useFavoriteNode hook", () => {
result.current.updateFavorite({ nodeNum: 9999, isFavorite: false }); result.current.updateFavorite({ nodeNum: 9999, isFavorite: false });
}); });
expect(mockToast).toHaveBeenCalledWith({ expect(mockUpdateFavorite).not.toHaveBeenCalled();
title: "Removed node from favorites", expect(mockToast).not.toHaveBeenCalled();
});
}); });
}); });

5
src/core/hooks/useFavoriteNode.ts

@ -13,9 +13,10 @@ export function useFavoriteNode() {
const updateFavoriteCB = useCallback( const updateFavoriteCB = useCallback(
({ nodeNum, isFavorite }: FavoriteNodeOptions) => { ({ nodeNum, isFavorite }: FavoriteNodeOptions) => {
updateFavorite(nodeNum, isFavorite);
const node = getNode(nodeNum); const node = getNode(nodeNum);
if (!node) return;
updateFavorite(nodeNum, isFavorite);
toast({ toast({
title: `${isFavorite ? "Added" : "Removed"} ${ title: `${isFavorite ? "Added" : "Removed"} ${

5
src/core/hooks/useIgnoreNode.test.ts

@ -90,8 +90,7 @@ describe("useIgnoreNode hook", () => {
result.current.updateIgnored({ nodeNum: 9999, isIgnored: false }); result.current.updateIgnored({ nodeNum: 9999, isIgnored: false });
}); });
expect(mockToast).toHaveBeenCalledWith({ expect(mockUpdateIgnore).not.toHaveBeenCalled();
title: "Removed node from ignore list", expect(mockToast).not.toHaveBeenCalled();
});
}); });
}); });

5
src/core/hooks/useIgnoreNode.ts

@ -13,9 +13,10 @@ export function useIgnoreNode() {
const updateIgnoredCB = useCallback( const updateIgnoredCB = useCallback(
({ nodeNum, isIgnored }: IgnoreNodeOptions) => { ({ nodeNum, isIgnored }: IgnoreNodeOptions) => {
updateIgnored(nodeNum, isIgnored);
const node = getNode(nodeNum); const node = getNode(nodeNum);
if (!node) return;
updateIgnored(nodeNum, isIgnored);
toast({ toast({
title: `${isIgnored ? "Added" : "Removed"} ${ title: `${isIgnored ? "Added" : "Removed"} ${

Loading…
Cancel
Save