From 847f19790bd7c91d5177b65a2ffb26856761eda0 Mon Sep 17 00:00:00 2001
From: philon- <philon-@users.noreply.github.com>
Date: Mon, 12 May 2025 20:14:55 +0200
Subject: [PATCH] Handle undefined node better

---
 src/core/hooks/useFavoriteNode.test.ts | 5 ++---
 src/core/hooks/useFavoriteNode.ts      | 5 +++--
 src/core/hooks/useIgnoreNode.test.ts   | 5 ++---
 src/core/hooks/useIgnoreNode.ts        | 5 +++--
 4 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/core/hooks/useFavoriteNode.test.ts b/src/core/hooks/useFavoriteNode.test.ts
index 6791bfc7..78732ace 100644
--- a/src/core/hooks/useFavoriteNode.test.ts
+++ b/src/core/hooks/useFavoriteNode.test.ts
@@ -87,8 +87,7 @@ describe("useFavoriteNode hook", () => {
       result.current.updateFavorite({ nodeNum: 9999, isFavorite: false });
     });
 
-    expect(mockToast).toHaveBeenCalledWith({
-      title: "Removed node from favorites",
-    });
+    expect(mockUpdateFavorite).not.toHaveBeenCalled();
+    expect(mockToast).not.toHaveBeenCalled();
   });
 });
diff --git a/src/core/hooks/useFavoriteNode.ts b/src/core/hooks/useFavoriteNode.ts
index 32dc1d0d..6bf6c808 100644
--- a/src/core/hooks/useFavoriteNode.ts
+++ b/src/core/hooks/useFavoriteNode.ts
@@ -13,9 +13,10 @@ export function useFavoriteNode() {
 
   const updateFavoriteCB = useCallback(
     ({ nodeNum, isFavorite }: FavoriteNodeOptions) => {
-      updateFavorite(nodeNum, isFavorite);
-
       const node = getNode(nodeNum);
+      if (!node) return;
+
+      updateFavorite(nodeNum, isFavorite);
 
       toast({
         title: `${isFavorite ? "Added" : "Removed"} ${
diff --git a/src/core/hooks/useIgnoreNode.test.ts b/src/core/hooks/useIgnoreNode.test.ts
index 8ec741f1..0bbe59f7 100644
--- a/src/core/hooks/useIgnoreNode.test.ts
+++ b/src/core/hooks/useIgnoreNode.test.ts
@@ -90,8 +90,7 @@ describe("useIgnoreNode hook", () => {
       result.current.updateIgnored({ nodeNum: 9999, isIgnored: false });
     });
 
-    expect(mockToast).toHaveBeenCalledWith({
-      title: "Removed node from ignore list",
-    });
+    expect(mockUpdateIgnore).not.toHaveBeenCalled();
+    expect(mockToast).not.toHaveBeenCalled();
   });
 });
diff --git a/src/core/hooks/useIgnoreNode.ts b/src/core/hooks/useIgnoreNode.ts
index 32dace9a..14b75974 100644
--- a/src/core/hooks/useIgnoreNode.ts
+++ b/src/core/hooks/useIgnoreNode.ts
@@ -13,9 +13,10 @@ export function useIgnoreNode() {
 
   const updateIgnoredCB = useCallback(
     ({ nodeNum, isIgnored }: IgnoreNodeOptions) => {
-      updateIgnored(nodeNum, isIgnored);
-
       const node = getNode(nodeNum);
+      if (!node) return;
+
+      updateIgnored(nodeNum, isIgnored);
 
       toast({
         title: `${isIgnored ? "Added" : "Removed"} ${