implemented rich comparison on SteamID

steam/steamid.py

@@ -113,11 +113,26 @@ class SteamID(object):
     def __str__(self):
         return str(self.as_64)
 
-    def __cmp__(self, other):
+    def __int__(self):
-        if isinstance(other, SteamID):
+        return self.as_64
-            return cmp(self.as_64, other.as_64)
+
-        else:
+    def __eq__(self, other):
-            raise RuntimeError("Can only compare SteamID instances")
+        return int(self) == int(other)
+
+    def __ne__(self, other):
+        return int(self) != int(other)
+
+    def __lt__(self, other):
+        return int(self) < int(other)
+
+    def __le__(self, other):
+        return int(self) <= int(other)
+
+    def __gt__(self, other):
+        return int(self) > int(other)
+
+    def __ge__(self, other):
+        return int(self) >= int(other)
 
     def __hash__(self):
         return hash(self.as_64)

tests/test_steamid.py

@@ -18,14 +18,14 @@ class SteamID_initialization(unittest.TestCase):
         self.assertEqual(hash(SteamID(1)), hash(SteamID(1)))
         self.assertNotEqual(hash(SteamID(12345)), hash(SteamID(8888)))
 
-    def test_cmp(self):
+    def test_rich_comperison(self):
-        self.assertEqual(SteamID(1), SteamID(1))
+        for test_value in [SteamID(5), 5, '5']:
-        self.assertTrue(SteamID(2) > SteamID(1))
+            self.assertFalse(SteamID(10) == test_value)
-        self.assertTrue(SteamID(2) < SteamID(4))
+            self.assertTrue(SteamID(10) != test_value)
-
+            self.assertTrue(SteamID(10) > test_value)
-        with self.assertRaises(RuntimeError):
+            self.assertTrue(SteamID(10) >= test_value)
-            a = SteamID(5) == 5
+            self.assertFalse(SteamID(10) < test_value)
-            b = SteamID(5) == '5'
+            self.assertFalse(SteamID(10) <= test_value)
 
     def test_is_valid(self):
         self.assertTrue(SteamID(1).is_valid())