From ed87854cc89af60324d92be882aa33557a84f45a Mon Sep 17 00:00:00 2001
From: Rossen Georgiev <rossen@rgp.io>
Date: Tue, 24 Nov 2015 21:28:36 +0200
Subject: [PATCH] implemented rich comparison on SteamID

---
 steam/steamid.py      | 25 ++++++++++++++++++++-----
 tests/test_steamid.py | 16 ++++++++--------
 2 files changed, 28 insertions(+), 13 deletions(-)

diff --git a/steam/steamid.py b/steam/steamid.py
index 0a71123..332a8db 100644
--- a/steam/steamid.py
+++ b/steam/steamid.py
@@ -113,11 +113,26 @@ class SteamID(object):
     def __str__(self):
         return str(self.as_64)
 
-    def __cmp__(self, other):
-        if isinstance(other, SteamID):
-            return cmp(self.as_64, other.as_64)
-        else:
-            raise RuntimeError("Can only compare SteamID instances")
+    def __int__(self):
+        return self.as_64
+
+    def __eq__(self, other):
+        return int(self) == int(other)
+
+    def __ne__(self, other):
+        return int(self) != int(other)
+
+    def __lt__(self, other):
+        return int(self) < int(other)
+
+    def __le__(self, other):
+        return int(self) <= int(other)
+
+    def __gt__(self, other):
+        return int(self) > int(other)
+
+    def __ge__(self, other):
+        return int(self) >= int(other)
 
     def __hash__(self):
         return hash(self.as_64)
diff --git a/tests/test_steamid.py b/tests/test_steamid.py
index 19982a7..1047ff7 100644
--- a/tests/test_steamid.py
+++ b/tests/test_steamid.py
@@ -18,14 +18,14 @@ class SteamID_initialization(unittest.TestCase):
         self.assertEqual(hash(SteamID(1)), hash(SteamID(1)))
         self.assertNotEqual(hash(SteamID(12345)), hash(SteamID(8888)))
 
-    def test_cmp(self):
-        self.assertEqual(SteamID(1), SteamID(1))
-        self.assertTrue(SteamID(2) > SteamID(1))
-        self.assertTrue(SteamID(2) < SteamID(4))
-
-        with self.assertRaises(RuntimeError):
-            a = SteamID(5) == 5
-            b = SteamID(5) == '5'
+    def test_rich_comperison(self):
+        for test_value in [SteamID(5), 5, '5']:
+            self.assertFalse(SteamID(10) == test_value)
+            self.assertTrue(SteamID(10) != test_value)
+            self.assertTrue(SteamID(10) > test_value)
+            self.assertTrue(SteamID(10) >= test_value)
+            self.assertFalse(SteamID(10) < test_value)
+            self.assertFalse(SteamID(10) <= test_value)
 
     def test_is_valid(self):
         self.assertTrue(SteamID(1).is_valid())