feat: add alert icon and footer to Discord alerts

- Added a new variable `alerticon` to store the URL of the alert icon image.
- Included the `alerticon` in the JSON payload for both short info and no info alerts.
- Added a footer with text "Sent by LinuxGSM v23.5.3" to the JSON payload for both short info and no info alerts.

This commit enhances the appearance of Discord alerts by adding an icon, a footer, and additional information about the sender.

lgsm/modules/alert.sh

@@ -174,6 +174,9 @@ fn_alert_info() {
 	alertcolourdec="2003199"
 }
 
+# Images
+alerticon="https://raw.githubusercontent.com/${githubuser}/${githubrepo}/${githubbranch}/lgsm/data/gameicons/${shortname}-icon.png"
+
 if [ "${alert}" == "permissions" ]; then
 	fn_alert_permissions
 elif [ "${alert}" == "monitor-session" ]; then

lgsm/modules/alert_discord.sh

@@ -10,20 +10,24 @@ moduleselfname="$(basename "$(readlink -f "${BASH_SOURCE[0]}")")"
 jsonshortinfo=$(
 	cat << EOF
 {
-	"username":"LinuxGSM",
-	"avatar_url":"https://raw.githubusercontent.com/${githubuser}/${githubrepo}/${githubbranch}/lgsm/data/alert_discord_logo.jpg",
-	"file":"content",
-	"embeds": [{
-		"color": "2067276",
+    "username": "LinuxGSM",
+    "avatar_url": "https://raw.githubusercontent.com/${githubuser}/${githubrepo}/${githubbranch}/lgsm/data/alert_discord_logo.jpg",
+    "file": "content",
+    "embeds": [
+        {
             "author": {
                 "name": "${alertemoji} ${alertsubject} ${alertemoji}",
+                "url": "",
                 "icon_url": "https://raw.githubusercontent.com/${githubuser}/${githubrepo}/${githubbranch}/lgsm/data/alert_discord_logo.jpg"
             },
             "title": "${servername}",
-		"description": "${alertbody} \n More info: ${alerturl}",
             "url": "",
+            "description": "${alertbody} \n More info: ${alerturl}",
+            "color": "${alertcolourdec}",
             "type": "content",
-		"thumbnail": {},
+            "thumbnail": {
+                "url": "${alerticon}"
+            },
             "fields": [
                 {
                     "name": "Game",
@@ -32,7 +36,7 @@ jsonshortinfo=$(
                 },
                 {
                     "name": "Server IP",
-				"value": "[${alertip}:${port}](https://www.gametracker.com/server_info/${alertip}:${port})",
+                    "value": "${alertip}:${port}",
                     "inline": true
                 },
                 {
@@ -40,8 +44,12 @@ jsonshortinfo=$(
                     "value": "${HOSTNAME}",
                     "inline": true
                 }
+            ],
+            "footer": {
+                "text": "Sent by LinuxGSM ${version}"
+            }
+        }
     ]
-	}]
 }
 EOF
 )
@@ -49,21 +57,24 @@ EOF
 jsonshortnoinfo=$(
 	cat << EOF
 {
-	"username":"LinuxGSM",
-	"avatar_url":"https://raw.githubusercontent.com/${githubuser}/${githubrepo}/${githubbranch}/lgsm/data/alert_discord_logo.jpg",
-	"file":"content",
-	"embeds": [{
-		"color": "2067276",
+    "username": "LinuxGSM",
+    "avatar_url": "https://raw.githubusercontent.com/${githubuser}/${githubrepo}/${githubbranch}/lgsm/data/alert_discord_logo.jpg",
+    "file": "content",
+    "embeds": [
+        {
             "author": {
                 "name": "${alertemoji} ${alertsubject} ${alertemoji}",
+                "url": "",
                 "icon_url": "https://raw.githubusercontent.com/${githubuser}/${githubrepo}/${githubbranch}/lgsm/data/alert_discord_logo.jpg"
             },
             "title": "${servername}",
+            "url": "",
             "description": "${alertbody}",
             "color": "${alertcolourdec}",
-		"url": "",
             "type": "content",
-		"thumbnail": {},
+            "thumbnail": {
+                "url": "${alerticon}"
+            },
             "fields": [
                 {
                     "name": "Game",
@@ -80,8 +91,12 @@ jsonshortnoinfo=$(
                     "value": "${HOSTNAME}",
                     "inline": true
                 }
+            ],
+            "footer": {
+                "text": "Sent by LinuxGSM ${version}"
+            }
+        }
     ]
-	}]
 }
 EOF
 )