Dependency checking can run as root (#2032)

* Only dependency checks will run as root user when starting the installer e.g `./csgoserver install`
* If running dep check as root LinuxGSM will remove any files in `lgsm` that belong to root
* Master server check will not run if jq missing

lgsm/functions/check.sh

@@ -10,12 +10,17 @@ local commandname="CHECK"
 # Every command that requires checks just references check.sh
 # check.sh selects which checks to run by using arrays
 
+if [ "${userinput}" != "install" ]&&[ "${userinput}" != "auto-install" ]&&[ "${userinput}" != "i" ]&&[ "${userinput}" != "ai" ]; then
 	check_root.sh
+fi
+
 check_tmuxception.sh
 
+if [ "$(whoami)" != "root" ]; then
 	if [ "${function_selfname}" != "command_monitor.sh" ]; then
 		check_permissions.sh
 	fi
+fi
 
 if [ "${function_selfname}" != "command_install.sh" ]&&[ "${function_selfname}" != "command_update_functions.sh" ]&&[ "${function_selfname}" != "command_update_linuxgsm.sh" ]&&[ "${function_selfname}" != "command_details.sh" ]&&[ "${function_selfname}" != "command_postdetails.sh" ]; then
 	check_system_dir.sh
@@ -29,6 +34,7 @@ do
 	fi
 done
 
+if [ "$(whoami)" != "root" ]; then
 	local allowed_commands_array=( command_debug.sh command_start.sh command_install.sh )
 	for allowed_command in "${allowed_commands_array[@]}"
 	do
@@ -36,6 +42,7 @@ do
 			check_glibc.sh
 		fi
 	done
+fi
 
 local allowed_commands_array=( command_backup.sh command_console.sh command_debug.sh command_details.sh command_unreal2_maps.sh command_fastdl.sh command_mods_install.sh command_mods_remove.sh command_mods_update.sh command_monitor.sh command_postdetails.sh command_restart.sh command_start.sh command_stop.sh command_test_alert.sh command_ts3_server_pass.sh command_update.sh command_update_functions.sh command_validate.sh command_wipe.sh command_unreal2_maps.sh command_ut99maps.sh)
 for allowed_command in "${allowed_commands_array[@]}"

lgsm/functions/check_deps.sh

@@ -179,10 +179,9 @@ fn_deps_email(){
 
 fn_found_missing_deps(){
 	if [ "${#array_deps_missing[@]}" != "0" ]; then
-		fn_print_dots "Checking dependencies"
-		sleep 0.5
-		fn_print_error_nl "Checking dependencies: missing: ${red}${array_deps_missing[@]}${default}"
-		fn_script_log_error "Checking dependencies: missing: ${array_deps_missing[@]}"
+
+		fn_print_warning_nl "Missing dependencies: ${red}${array_deps_missing[@]}${default}"
+		fn_script_log_warn "Missing dependencies: ${array_deps_missing[@]}"
 		sleep 0.5
 		if [ -n "${monostatus}" ]; then
 			fn_install_mono_repo
@@ -257,6 +256,9 @@ fn_found_missing_deps(){
 		if [ "${function_selfname}" == "command_install.sh" ]; then
 			sleep 5
 		fi
+	else
+		fn_print_information_nl "Required dependencies already installed"
+		fn_script_log_info "Required dependencies already installed"
 	fi
 }
 
@@ -482,10 +484,19 @@ fn_deps_build_redhat(){
 }
 
 if [ "${function_selfname}" == "command_install.sh" ]; then
+	if [ "$(whoami)" == "root" ]; then
+		echo ""
+		echo "Checking Dependencies as root"
+		echo "================================="
+		fn_print_information_nl "Checking any missing dependencies for ${gamename} server only."
+		fn_print_information_nl "This will NOT install a ${gamename} server."
+		sleep 2
+	else
 		echo ""
 		echo "Checking Dependencies"
 		echo "================================="
 	fi
+fi
 
 # Filter checking in to Debian or Red Hat Based
 info_distro.sh

lgsm/functions/check_permissions.sh

@@ -230,8 +230,10 @@ fn_sys_perm_error_process(){
 # Run perm error detect & fix/alert functions on /sys directories
 
 ## Run checks
+if [ "$(whoami)" != "root" ]; then
 	fn_check_ownership
 	fn_check_permissions
 	if [ "${function_selfname}" == "command_start.sh" ]; then
 		fn_sys_perm_error_process
 	fi
+fi

lgsm/functions/check_root.sh

@@ -8,9 +8,11 @@ local commandname="CHECK"
 local function_selfname="$(basename "$(readlink -f "${BASH_SOURCE[0]}")")"
 
 if [ "$(whoami)" = "root" ]; then
+	if [ "${function_selfname}" != "command_install.sh" ]; then
 		fn_print_fail_nl "Do NOT run this script as root!"
 		if [ -d "${lgsmlogdir}" ]; then
 			fn_script_log_fatal "${selfname} attempted to run as root."
 		fi
 		core_exit.sh
 	fi
+fi

lgsm/functions/command_install.sh

@@ -10,6 +10,9 @@ local commandaction="Install"
 local function_selfname="$(basename "$(readlink -f "${BASH_SOURCE[0]}")")"
 
 check.sh
+if [ "$(whoami)" = "root" ]; then
+	check_deps.sh
+else
 	install_header.sh
 	install_server_dir.sh
 	install_logs.sh
@@ -44,3 +47,4 @@ fi
 	fix.sh
 	install_complete.sh
 	core_exit.sh
+fi

lgsm/functions/core_exit.sh

@@ -14,6 +14,12 @@ fn_exit_dev_debug(){
 	fi
 }
 
+# If running dependency check as root will remove any files that belong to root user.
+if [ "$(whoami)" == "root" ]; then
+	find "${lgsmdir}"/ -group root -prune -exec rm -rf {} + > /dev/null 2>&1
+	find "${logdir}"/ -group root -prune -exec rm -rf {} + > /dev/null 2>&1
+fi
+
 if [ -n "${exitbypass}" ]; then
 	unset exitbypass
 elif [ -n "${exitcode}" ]&&[ "${exitcode}" != "0" ]; then

lgsm/functions/info_distro.sh

@@ -174,6 +174,7 @@ if [ -z "${extip}" ]; then
 fi
 
 # Steam Master Server - checks if detected by master server
+if [ ! "$(command -v jq 2>/dev/null)" ]; then
 	if [ "${ip}" ] && [ "${port}" ]; then
 		if [ "${engine}" == "source" ]||[ "${engine}" == "goldsource" ]||[ "${shortname}" == "jc2" ]||[ "${shortname}" == "ql" ]; then
 			masterserver=$(${curlpath} -s 'https://api.steampowered.com/ISteamApps/GetServersAtAddress/v0001?addr='${ip}':'${port}'&format=json' | jq '.response.servers[]|.addr' | wc -l)
@@ -184,3 +185,4 @@ if [ "${ip}" ] && [ "${port}" ]; then
 			fi
 		fi
 	fi
+fi

linuxgsm.sh

@@ -20,7 +20,7 @@ if [ -f ".dev-debug" ]; then
 	set -x
 fi
 
-version="180908"
+version="181007"
 shortname="core"
 gameservername="core"
 rootdir="$(dirname "$(readlink -f "${BASH_SOURCE[0]}")")"
@@ -38,6 +38,7 @@ tmpdir="${lgsmdir}/tmp"
 configdir="${lgsmdir}/config-lgsm"
 configdirserver="${configdir}/${gameservername}"
 configdirdefault="${lgsmdir}/config-default"
+userinput="${1}"
 
 ## GitHub Branch Select
 # Allows for the use of different function files
@@ -254,9 +255,14 @@ fn_install_file(){
 	exit
 }
 
-# Prevent from running this script as root.
+# Prevent LinuxGSM from running as root. Except if doing a dependency install.
 if [ "$(whoami)" == "root" ]; then
-	if [ ! -f "${functionsdir}/core_functions.sh" ]||[ ! -f "${functionsdir}/check_root.sh" ]||[ ! -f "${functionsdir}/core_messages.sh" ]; then
+	if [ "${userinput}" == "install" ]||[ "${userinput}" == "auto-install" ]||[ "${userinput}" == "i" ]||[ "${userinput}" == "ai" ]; then
+		if [ "${shortname}" == "core" ]; then
+			echo "[ FAIL ] Do NOT run this script as root!"
+			exit 1
+		fi
+	elif [ ! -f "${functionsdir}/core_functions.sh" ]||[ ! -f "${functionsdir}/check_root.sh" ]||[ ! -f "${functionsdir}/core_messages.sh" ]; then
 		echo "[ FAIL ] Do NOT run this script as root!"
 		exit 1
 	else
@@ -267,7 +273,6 @@ fi
 
 # LinuxGSM installer mode
 if [ "${shortname}" == "core" ]; then
-	userinput=$1
 	datadir="${tmpdir}/data"
 	serverlist="${datadir}/serverlist.csv"
 
@@ -310,7 +315,7 @@ if [ "${shortname}" == "core" ]; then
 # LinuxGSM Server Mode
 else
 	core_functions.sh
-
+	if [ "${shortname}" != "core-dep" ]; then
 		# Load LinuxGSM configs
 		# These are required to get all the default variables for the specific server.
 		# Load the default config. If missing download it. If changed reload it.
@@ -364,6 +369,7 @@ else
 		if [ ! -f "${tmpdir}/linuxgsm.sh" ]; then
 			fn_fetch_file_github "" "linuxgsm.sh" "${tmpdir}" "chmodx" "norun" "noforcedl" "nomd5"
 		fi
+	fi
 	# Enables ANSI colours from core_messages.sh. Can be disabled with ansi=off
 	fn_ansi_loader
 	# Prevents running of core_exit.sh for Travis.