Browse Source

fix(steamcmd): address Copilot review feedback on libtinfo symlink fix

- Iterate over all candidate steamcmd dirs (HOME/.steam/steamcmd,
  steamcmddir, HOME/.local/share/Steam/steamcmd) matching the pattern
  used for steamclient.so fixes elsewhere in the module
- Replace '! -f && ! -L' guard with '! -e' so broken/dangling symlinks
  are also repaired rather than silently skipped
- Add mkdir -p before ln in case the directory does not exist yet
- Capture exitcode=$? after ln so fn_fix_msg_end reports failures
pull/4899/head
LinuxGSM 1 month ago
parent
commit
3ab837ff2f
  1. 10
      lgsm/modules/fix_steamcmd.sh

10
lgsm/modules/fix_steamcmd.sh

@ -117,20 +117,26 @@ fi
# On distros that ship libtinfo.so.6 (e.g. Ubuntu 22.04+, Debian 12+) but not
# libtinfo.so.5, SteamCMD prints this warning and loses readline support.
# Creating a symlink from .so.5 -> .so.6 resolves the warning without root.
libtinfo32dir="${HOME}/.steam/steamcmd"
for libtinfo32dir in "${HOME}/.steam/steamcmd" "${steamcmddir}" "${HOME}/.local/share/Steam/steamcmd"; do
if [ -d "${libtinfo32dir}" ]; then
libtinfo32so="${libtinfo32dir}/libtinfo.so.5"
if [ ! -f "${libtinfo32so}" ] && [ ! -L "${libtinfo32so}" ]; then
# Also repair broken symlinks (! -e catches missing target, -L catches dangling link)
if [ ! -e "${libtinfo32so}" ]; then
# Find the .so.6 in the system 32-bit lib paths
for libtinfo32so6 in /lib/i386-linux-gnu/libtinfo.so.6 /usr/lib/i386-linux-gnu/libtinfo.so.6 /lib32/libtinfo.so.6; do
if [ -f "${libtinfo32so6}" ]; then
fixname="libtinfo.so.5 32-bit symlink"
fn_fix_msg_start
mkdir -p "${libtinfo32dir}"
ln -sf "${libtinfo32so6}" "${libtinfo32so}"
exitcode=$?
fn_fix_msg_end
break
fi
done
fi
fi
done
# steamclient.so fixes
if [ "${shortname}" == "bo" ]; then

Loading…
Cancel
Save