Browse Source
Commit c87ccd0 ("Move .golangci to workflows") relocated this file from
the repo root into .github/workflows/, but it isn't a GitHub Actions
workflow — it's the configuration file for golangci-lint. Two
consequences of leaving it under .github/workflows/:
1. GitHub Actions discovers every .yml in .github/workflows/ as a
candidate workflow file and tries to parse it. Since the contents
are linter-config (`linters: enable: ...`) rather than a valid
workflow definition, every push triggers a phantom failed Action
run with "This run likely failed because of a workflow file issue"
and 0s duration. Visible at e.g.
https://github.com/anton48/vk-turn-proxy/actions/runs/25236737441
on a recent fork's branch — same failure shape on every push to
any branch in any fork.
2. golangci-lint-action (in ci.yml) auto-discovers config from the
repo root by default. With the file in .github/workflows/ the
action falls back to default rules and silently ignores the
project-specific exclusions (errcheck excluded functions for pion
DTLS / net.PacketConn writes, govet field-alignment disable, the
curated revive rule list, etc.).
Moving it back to root restores both: the phantom workflow failure
goes away, and golangci-lint picks up the intended config.
No content change — just `git mv`.
pull/169/head
Anton Monakhov
2 months ago
1 changed files with 0 additions and 0 deletions
Loading…
Reference in new issue