From cdba8481c2773bfca903c439b052199ebea1eda0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebasti=C3=A1n=20Ram=C3=ADrez?= Date: Sun, 9 Aug 2020 22:32:59 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A5=20Remove=20old/unused=20parameter?= =?UTF-8?q?=20sqlalchemy=5Fsafe=20from=20jsonable=5Fencoder=20(#1864)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- fastapi/encoders.py | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/fastapi/encoders.py b/fastapi/encoders.py index 1255b7497..1c324b915 100644 --- a/fastapi/encoders.py +++ b/fastapi/encoders.py @@ -32,7 +32,6 @@ def jsonable_encoder( exclude_defaults: bool = False, exclude_none: bool = False, custom_encoder: dict = {}, - sqlalchemy_safe: bool = True, ) -> Any: if include is not None and not isinstance(include, set): include = set(include) @@ -57,7 +56,6 @@ def jsonable_encoder( exclude_none=exclude_none, exclude_defaults=exclude_defaults, custom_encoder=encoder, - sqlalchemy_safe=sqlalchemy_safe, ) if isinstance(obj, Enum): return obj.value @@ -68,14 +66,8 @@ def jsonable_encoder( if isinstance(obj, dict): encoded_dict = {} for key, value in obj.items(): - if ( - ( - not sqlalchemy_safe - or (not isinstance(key, str)) - or (not key.startswith("_sa")) - ) - and (value is not None or not exclude_none) - and ((include and key in include) or not exclude or key not in exclude) + if (value is not None or not exclude_none) and ( + (include and key in include) or not exclude or key not in exclude ): encoded_key = jsonable_encoder( key, @@ -83,7 +75,6 @@ def jsonable_encoder( exclude_unset=exclude_unset, exclude_none=exclude_none, custom_encoder=custom_encoder, - sqlalchemy_safe=sqlalchemy_safe, ) encoded_value = jsonable_encoder( value, @@ -91,7 +82,6 @@ def jsonable_encoder( exclude_unset=exclude_unset, exclude_none=exclude_none, custom_encoder=custom_encoder, - sqlalchemy_safe=sqlalchemy_safe, ) encoded_dict[encoded_key] = encoded_value return encoded_dict @@ -108,7 +98,6 @@ def jsonable_encoder( exclude_defaults=exclude_defaults, exclude_none=exclude_none, custom_encoder=custom_encoder, - sqlalchemy_safe=sqlalchemy_safe, ) ) return encoded_list @@ -144,5 +133,4 @@ def jsonable_encoder( exclude_defaults=exclude_defaults, exclude_none=exclude_none, custom_encoder=custom_encoder, - sqlalchemy_safe=sqlalchemy_safe, )