Browse Source

🔥 Remove logic for development dependencies and Jupyter, it was never documented, and I no longer use that trick (#1355)

pull/13907/head
Sebastián Ramírez 10 months ago
committed by GitHub
parent
commit
c8104d8ced
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 4
      backend/Dockerfile
  2. 3
      docker-compose.override.yml
  3. 4
      docker-compose.yml

4
backend/Dockerfile

@ -11,9 +11,7 @@ RUN curl -sSL https://install.python-poetry.org | POETRY_HOME=/opt/poetry python
# Copy poetry.lock* in case it doesn't exist in the repo
COPY ./pyproject.toml ./poetry.lock* /app/
# Allow installing dev dependencies to run tests
ARG INSTALL_DEV=false
RUN bash -c "if [ $INSTALL_DEV == 'true' ] ; then poetry install --no-root ; else poetry install --no-root --only main ; fi"
RUN poetry install --no-root
ENV PYTHONPATH=/app

3
docker-compose.override.yml

@ -58,12 +58,9 @@ services:
backend:
restart: "no"
ports:
- "8888:8888"
- "8000:8000"
build:
context: ./backend
args:
INSTALL_DEV: ${INSTALL_DEV-true}
# command: sleep infinity # Infinite loop to keep container alive doing nothing
command:
- fastapi

4
docker-compose.yml

@ -46,8 +46,6 @@ services:
image: '${DOCKER_IMAGE_BACKEND?Variable not set}:${TAG-latest}'
build:
context: ./backend
args:
INSTALL_DEV: ${INSTALL_DEV-false}
networks:
- traefik-public
- default
@ -118,8 +116,6 @@ services:
build:
context: ./backend
args:
INSTALL_DEV: ${INSTALL_DEV-false}
labels:
- traefik.enable=true
- traefik.docker.network=traefik-public

Loading…
Cancel
Save