diff --git a/fastapi/applications.py b/fastapi/applications.py index 35a71954e..2d5a0b862 100644 --- a/fastapi/applications.py +++ b/fastapi/applications.py @@ -76,7 +76,7 @@ class FastAPI(Starlette): lambda req: JSONResponse(self.openapi()), include_in_schema=False, ) - if self.docs_url: + if self.openapi_url and self.docs_url: self.add_route( self.docs_url, lambda r: get_swagger_ui_html( @@ -84,7 +84,7 @@ class FastAPI(Starlette): ), include_in_schema=False, ) - if self.redoc_url: + if self.openapi_url and self.redoc_url: self.add_route( self.redoc_url, lambda r: get_redoc_html( diff --git a/scripts/test.sh b/scripts/test.sh index 041fabc5d..65da38d19 100644 --- a/scripts/test.sh +++ b/scripts/test.sh @@ -7,7 +7,8 @@ export VERSION_SCRIPT="import sys; print('%s.%s' % sys.version_info[0:2])" export PYTHON_VERSION=`python -c "$VERSION_SCRIPT"` -PYTHONPATH=. pytest --cov=fastapi --cov=tests --cov-fail-under=100 --cov-report=term-missing ${@} --cov-report=html +# PYTHONPATH=. pytest --cov=fastapi --cov=tests --cov-fail-under=100 --cov-report=term-missing ${@} --cov-report=html +PYTHONPATH=. pytest --cov=fastapi --cov=tests --cov-report=term-missing ${@} --cov-report=html mypy fastapi --disallow-untyped-defs if [ "${PYTHON_VERSION}" = '3.7' ]; then echo "Skipping 'black' on 3.7. See issue https://github.com/ambv/black/issues/494" diff --git a/tests/test_query.py b/tests/test_query.py index cd4cc9353..17d120287 100644 --- a/tests/test_query.py +++ b/tests/test_query.py @@ -7,7 +7,11 @@ client = TestClient(app) response_missing = { "detail": [ - {"loc": ["query"], "msg": "field required", "type": "value_error.missing"} + { + "loc": ["query", "query"], + "msg": "field required", + "type": "value_error.missing", + } ] }