From a6d187025d8406dcb84e9524eed9a1f3cb80eb11 Mon Sep 17 00:00:00 2001 From: Valentyn Druzhynin Date: Thu, 20 Mar 2025 08:45:06 -0400 Subject: [PATCH] Fixes after review --- .../test_settings/test_tutorial001.py | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/tests/test_tutorial/test_settings/test_tutorial001.py b/tests/test_tutorial/test_settings/test_tutorial001.py index 4f73cd1bd..92a5782d4 100644 --- a/tests/test_tutorial/test_settings/test_tutorial001.py +++ b/tests/test_tutorial/test_settings/test_tutorial001.py @@ -8,23 +8,19 @@ from ...utils import needs_pydanticv1, needs_pydanticv2 @pytest.fixture( + name="app", params=[ pytest.param("tutorial001", marks=needs_pydanticv2), pytest.param("tutorial001_pv1", marks=needs_pydanticv1), ], ) -def get_app(request: pytest.FixtureRequest): - def app_wrapper(): - mod = importlib.import_module(f"docs_src.settings.{request.param}") - return mod.app - - return app_wrapper - - -def test_settings(get_app, monkeypatch: MonkeyPatch): +def get_app(request: pytest.FixtureRequest, monkeypatch: MonkeyPatch): monkeypatch.setenv("ADMIN_EMAIL", "admin@example.com") + mod = importlib.import_module(f"docs_src.settings.{request.param}") + return mod.app + - app = get_app() +def test_settings(app): client = TestClient(app) response = client.get("/info") assert response.status_code == 200, response.text