Merge 392170d116 into 6df50d40fe

fastapi/_compat.py

@@ -269,7 +269,10 @@ if PYDANTIC_V2:
         origin_type = (
             get_origin(field.field_info.annotation) or field.field_info.annotation
         )
-        assert issubclass(origin_type, sequence_types)  # type: ignore[arg-type]
+        if not issubclass(origin_type, sequence_types) or not isinstance(
+            origin_type, type
+        ):
+            raise TypeError(f"Field {field.name} is not a supported sequence type")
         return sequence_annotation_to_type[origin_type](value)  # type: ignore[no-any-return]
 
     def get_missing_field_error(loc: Tuple[str, ...]) -> Dict[str, Any]:

fastapi/applications.py

@@ -872,8 +872,12 @@ class FastAPI(Starlette):
         ] = "3.1.0"
         self.openapi_schema: Optional[Dict[str, Any]] = None
         if self.openapi_url:
-            assert self.title, "A title must be provided for OpenAPI, e.g.: 'My API'"
-            assert self.version, "A version must be provided for OpenAPI, e.g.: '2.1.0'"
+            if not self.title:
+                raise ValueError("A title must be provided for OpenAPI, e.g.: 'My API'")
+            if not self.version:
+                raise ValueError(
+                    "A version must be provided for OpenAPI, e.g.: '2.1.0'"
+                )
         # TODO: remove when discarding the openapi_prefix parameter
         if openapi_prefix:
             logger.warning(

fastapi/dependencies/utils.py

@@ -90,29 +90,42 @@ multipart_incorrect_install_error = (
 
 def ensure_multipart_is_installed() -> None:
     try:
-        from python_multipart import __version__
+        from python_multipart import __version__ as python_multipart_version
 
         # Import an attribute that can be mocked/deleted in testing
-        assert __version__ > "0.0.12"
-    except (ImportError, AssertionError):
-        try:
-            # __version__ is available in both multiparts, and can be mocked
-            from multipart import __version__  # type: ignore[no-redef,import-untyped]
+        if python_multipart_version <= "0.0.12":
+            raise RuntimeError(
+                f"Incompatible 'python-multipart' version: {python_multipart_version}. "
+                "Please upgrade to a version > 0.0.12"
+            )
+        return
 
-            assert __version__
-            try:
-                # parse_options_header is only available in the right multipart
-                from multipart.multipart import (  # type: ignore[import-untyped]
-                    parse_options_header,
-                )
+    except ImportError:
+        pass  # fallback to trying multipart
+    except Exception as e:
+        logger.error("Error checking 'python-multipart' version: %s", e)
+        raise
+
+    try:
+        # __version__ is available in both multiparts, and can be mocked
+        from multipart import (
+            __version__ as multipart_version,  # type: ignore[no-redef,import-untyped]
+        )
+    except ImportError:
+        logger.error(multipart_not_installed_error)
+        raise RuntimeError(multipart_not_installed_error) from None
 
-                assert parse_options_header
-            except ImportError:
-                logger.error(multipart_incorrect_install_error)
-                raise RuntimeError(multipart_incorrect_install_error) from None
-        except ImportError:
-            logger.error(multipart_not_installed_error)
-            raise RuntimeError(multipart_not_installed_error) from None
+    if not multipart_version:
+        logger.error(multipart_incorrect_install_error)
+        raise RuntimeError(multipart_incorrect_install_error)
+
+    try:
+        from multipart.multipart import (
+            parse_options_header,  # type: ignore[import-untyped]
+        )
+    except ImportError:
+        logger.error(multipart_incorrect_install_error)
+        raise RuntimeError(multipart_incorrect_install_error) from None
 
 
 def get_param_sub_dependant(
@@ -122,7 +135,11 @@ def get_param_sub_dependant(
     path: str,
     security_scopes: Optional[List[str]] = None,
 ) -> Dependant:
-    assert depends.dependency
+    if depends.dependency is None:
+        raise ValueError(
+            f"`depends.dependency` must be set for parameter '{param_name}'"
+        )
+
     return get_sub_dependant(
         depends=depends,
         dependency=depends.dependency,
@@ -133,9 +150,9 @@ def get_param_sub_dependant(
 
 
 def get_parameterless_sub_dependant(*, depends: params.Depends, path: str) -> Dependant:
-    assert callable(depends.dependency), (
-        "A parameter-less dependency must have a callable dependency"
-    )
+    if not callable(depends.dependency):
+        raise TypeError("A parameter-less dependency must have a callable dependency")
+
     return get_sub_dependant(depends=depends, dependency=depends.dependency, path=path)
 
 
@@ -302,11 +319,16 @@ def get_dependant(
             type_annotation=param_details.type_annotation,
             dependant=dependant,
         ):
-            assert param_details.field is None, (
-                f"Cannot specify multiple FastAPI annotations for {param_name!r}"
-            )
+            if param_details.field is not None:
+                raise ValueError(
+                    f"Cannot specify multiple FastAPI annotations for {param_name!r}"
+                )
+
             continue
-        assert param_details.field is not None
+
+        if param_details.field is None:
+            raise ValueError("Expected param_details.field to be set, but got None")
+
         if isinstance(param_details.field.field_info, params.Body):
             dependant.body_params.append(param_details.field)
         else:
@@ -385,14 +407,20 @@ def analyze_param(
             field_info = copy_field_info(
                 field_info=fastapi_annotation, annotation=use_annotation
             )
-            assert (
-                field_info.default is Undefined or field_info.default is RequiredParam
-            ), (
-                f"`{field_info.__class__.__name__}` default value cannot be set in"
-                f" `Annotated` for {param_name!r}. Set the default value with `=` instead."
-            )
+
+            if (
+                field_info.default is not Undefined
+                and field_info.default is not RequiredParam
+            ):
+                raise ValueError(
+                    f"`{field_info.__class__.__name__}` default value cannot be set in "
+                    f"`Annotated` for {param_name!r}. Set the default value with `=` instead."
+                )
+
             if value is not inspect.Signature.empty:
-                assert not is_path_param, "Path parameters cannot have default values"
+                if is_path_param:
+                    raise ValueError("Path parameters cannot have default values")
+
                 field_info.default = value
             else:
                 field_info.default = RequiredParam
@@ -401,21 +429,26 @@ def analyze_param(
             depends = fastapi_annotation
     # Get Depends from default value
     if isinstance(value, params.Depends):
-        assert depends is None, (
-            "Cannot specify `Depends` in `Annotated` and default value"
-            f" together for {param_name!r}"
-        )
-        assert field_info is None, (
-            "Cannot specify a FastAPI annotation in `Annotated` and `Depends` as a"
-            f" default value together for {param_name!r}"
-        )
+        if depends is not None:
+            raise ValueError(
+                f"Cannot specify `Depends` in `Annotated` and a default value together for {param_name!r}"
+            )
+
+        if field_info is not None:
+            raise ValueError(
+                f"Cannot specify a FastAPI annotation in `Annotated` and `Depends` as a default value "
+                f"together for {param_name!r}"
+            )
+
         depends = value
     # Get FieldInfo from default value
     elif isinstance(value, FieldInfo):
-        assert field_info is None, (
-            "Cannot specify FastAPI annotations in `Annotated` and default value"
-            f" together for {param_name!r}"
-        )
+        if field_info is not None:
+            raise ValueError(
+                f"Cannot specify FastAPI annotations in `Annotated` and a default value "
+                f"together for {param_name!r}"
+            )
+
         field_info = value
         if PYDANTIC_V2:
             field_info.annotation = type_annotation
@@ -438,10 +471,14 @@ def analyze_param(
             SecurityScopes,
         ),
     ):
-        assert depends is None, f"Cannot specify `Depends` for type {type_annotation!r}"
-        assert field_info is None, (
-            f"Cannot specify FastAPI annotation for type {type_annotation!r}"
-        )
+        if depends is not None:
+            raise ValueError(f"Cannot specify `Depends` for type {type_annotation!r}")
+
+        if field_info is not None:
+            raise ValueError(
+                f"Cannot specify FastAPI annotation for type {type_annotation!r}"
+            )
+
     # Handle default assignations, neither field_info nor depends was not found in Annotated nor default value
     elif field_info is None and depends is None:
         default_value = value if value is not inspect.Signature.empty else RequiredParam
@@ -464,10 +501,11 @@ def analyze_param(
     if field_info is not None:
         # Handle field_info.in_
         if is_path_param:
-            assert isinstance(field_info, params.Path), (
-                f"Cannot use `{field_info.__class__.__name__}` for path param"
-                f" {param_name!r}"
-            )
+            if not isinstance(field_info, params.Path):
+                raise TypeError(
+                    f"Cannot use `{field_info.__class__.__name__}` for path param {param_name!r}"
+                )
+
         elif (
             isinstance(field_info, params.Param)
             and getattr(field_info, "in_", None) is None
@@ -494,19 +532,25 @@ def analyze_param(
             field_info=field_info,
         )
         if is_path_param:
-            assert is_scalar_field(field=field), (
-                "Path params must be of one of the supported types"
-            )
+            if not is_scalar_field(field=field):
+                raise TypeError(
+                    "Path parameters must be of one of the supported scalar types"
+                )
+
         elif isinstance(field_info, params.Query):
-            assert (
+            if not (
                 is_scalar_field(field)
                 or is_scalar_sequence_field(field)
                 or (
-                    lenient_issubclass(field.type_, BaseModel)
-                    # For Pydantic v1
-                    and getattr(field, "shape", 1) == 1
+                    isinstance(field.type_, type)
+                    and issubclass(field.type_, BaseModel)
+                    and getattr(field, "shape", 1) == 1  # shape check for Pydantic v1
+                )
+            ):
+                raise TypeError(
+                    f"Query parameter {field.name!r} must be a supported scalar, sequence, "
+                    "or a non-nested Pydantic model (shape == 1)"
                 )
-            )
 
     return ParamDetails(type_annotation=type_annotation, depends=depends, field=field)
 
@@ -521,9 +565,11 @@ def add_param_to_fields(*, field: ModelField, dependant: Dependant) -> None:
     elif field_info_in == params.ParamTypes.header:
         dependant.header_params.append(field)
     else:
-        assert field_info_in == params.ParamTypes.cookie, (
-            f"non-body parameters must be in path, query, header or cookie: {field.name}"
-        )
+        if field_info_in != params.ParamTypes.cookie:
+            raise ValueError(
+                f"Non-body parameters must be in path, query, header, or cookie: {field.name}"
+            )
+
         dependant.cookie_params.append(field)
 
 
@@ -790,9 +836,9 @@ def request_params_to_args(
 
     if single_not_embedded_field:
         field_info = first_field.field_info
-        assert isinstance(field_info, params.Param), (
-            "Params must be subclasses of Param"
-        )
+        if not isinstance(field_info, params.Param):
+            raise TypeError("Params must be subclasses of Param")
+
         loc: Tuple[str, ...] = (field_info.in_.value,)
         v_, errors_ = _validate_value_with_model_field(
             field=first_field, value=params_to_process, values=values, loc=loc
@@ -802,9 +848,11 @@ def request_params_to_args(
     for field in fields:
         value = _get_multidict_value(field, received_params)
         field_info = field.field_info
-        assert isinstance(field_info, params.Param), (
-            "Params must be subclasses of Param"
-        )
+        if not isinstance(field_info, params.Param):
+            raise TypeError(
+                f"Invalid parameter type: expected a subclass of Param, got {type(field_info).__name__}"
+            )
+
         loc = (field_info.in_.value, field.alias)
         v_, errors_ = _validate_value_with_model_field(
             field=field, value=value, values=values, loc=loc
@@ -881,7 +929,11 @@ async def _extract_form_body(
             and value_is_sequence(value)
         ):
             # For types
-            assert isinstance(value, sequence_types)  # type: ignore[arg-type]
+            if not isinstance(value, sequence_types):
+                raise TypeError(
+                    f"Expected a sequence type (e.g., list, tuple), got {type(value).__name__}"
+                )
+
             results: List[Union[bytes, str]] = []
 
             async def process_fn(
@@ -909,7 +961,12 @@ async def request_body_to_args(
 ) -> Tuple[Dict[str, Any], List[Dict[str, Any]]]:
     values: Dict[str, Any] = {}
     errors: List[Dict[str, Any]] = []
-    assert body_fields, "request_body_to_args() should be called with fields"
+
+    if not body_fields:
+        raise ValueError(
+            "request_body_to_args() should be called with at least one field"
+        )
+
     single_not_embedded_field = len(body_fields) == 1 and not embed_body_fields
     first_field = body_fields[0]
     body_to_process = received_body

fastapi/openapi/models.py

@@ -15,9 +15,7 @@ from typing_extensions import Annotated, Literal, TypedDict
 from typing_extensions import deprecated as typing_deprecated
 
 try:
-    import email_validator
-
-    assert email_validator  # make autoflake ignore the unused import
+    import email_validator  # noqa: F401
     from pydantic import EmailStr
 except ImportError:  # pragma: no cover
 

fastapi/openapi/utils.py

@@ -179,7 +179,12 @@ def get_openapi_operation_request_body(
 ) -> Optional[Dict[str, Any]]:
     if not body_field:
         return None
-    assert isinstance(body_field, ModelField)
+
+    if not isinstance(body_field, ModelField):
+        raise TypeError(
+            f"Expected body_field to be a ModelField, got {type(body_field).__name__}"
+        )
+
     body_schema = get_schema_from_model_field(
         field=body_field,
         schema_generator=schema_generator,
@@ -265,12 +270,18 @@ def get_openapi_path(
     path = {}
     security_schemes: Dict[str, Any] = {}
     definitions: Dict[str, Any] = {}
-    assert route.methods is not None, "Methods must be a list"
+
+    if route.methods is None:
+        raise ValueError("Route methods must be defined as a list of HTTP methods")
+
     if isinstance(route.response_class, DefaultPlaceholder):
         current_response_class: Type[Response] = route.response_class.value
     else:
         current_response_class = route.response_class
-    assert current_response_class, "A response class is needed to generate OpenAPI"
+
+    if not current_response_class:
+        raise ValueError("A response class is needed to generate OpenAPI")
+
     route_response_media_type: Optional[str] = current_response_class.media_type
     if route.include_in_schema:
         for method in route.methods:
@@ -385,9 +396,10 @@ def get_openapi_path(
                     openapi_response = operation_responses.setdefault(
                         status_code_key, {}
                     )
-                    assert isinstance(process_response, dict), (
-                        "An additional response must be a dict"
-                    )
+
+                    if not isinstance(process_response, dict):
+                        raise TypeError("An additional response must be a dict")
+
                     field = route.response_fields.get(additional_status_code)
                     additional_field_schema: Optional[Dict[str, Any]] = None
                     if field:
@@ -455,9 +467,11 @@ def get_fields_from_routes(
             route, routing.APIRoute
         ):
             if route.body_field:
-                assert isinstance(route.body_field, ModelField), (
-                    "A request body must be a Pydantic Field"
-                )
+                if not isinstance(route.body_field, ModelField):
+                    raise TypeError(
+                        "A request body must be a Pydantic ModelField instance"
+                    )
+
                 body_fields_from_routes.append(route.body_field)
             if route.response_field:
                 responses_from_routes.append(route.response_field)

fastapi/params.py

@@ -186,7 +186,9 @@ class Path(Param):
         json_schema_extra: Union[Dict[str, Any], None] = None,
         **extra: Any,
     ):
-        assert default is ..., "Path parameters cannot have a default value"
+        if default is ...:
+            raise ValueError("Path parameters cannot have a default value")
+
         self.in_ = self.in_
         super().__init__(
             default=default,

fastapi/responses.py

@@ -1,12 +1,14 @@
 from typing import Any
 
-from starlette.responses import FileResponse as FileResponse  # noqa
-from starlette.responses import HTMLResponse as HTMLResponse  # noqa
-from starlette.responses import JSONResponse as JSONResponse  # noqa
-from starlette.responses import PlainTextResponse as PlainTextResponse  # noqa
-from starlette.responses import RedirectResponse as RedirectResponse  # noqa
-from starlette.responses import Response as Response  # noqa
-from starlette.responses import StreamingResponse as StreamingResponse  # noqa
+from starlette.responses import (  # noqa: F401
+    FileResponse,  # noqa: F401
+    HTMLResponse,  # noqa: F401
+    JSONResponse,  # noqa: F401
+    PlainTextResponse,  # noqa: F401
+    RedirectResponse,  # noqa: F401
+    Response,  # noqa: F401
+    StreamingResponse,  # noqa: F401
+)
 
 try:
     import ujson
@@ -29,7 +31,8 @@ class UJSONResponse(JSONResponse):
     """
 
     def render(self, content: Any) -> bytes:
-        assert ujson is not None, "ujson must be installed to use UJSONResponse"
+        if ujson is None:
+            raise RuntimeError("ujson must be installed to use UJSONResponse")
         return ujson.dumps(content, ensure_ascii=False).encode("utf-8")
 
 
@@ -42,7 +45,9 @@ class ORJSONResponse(JSONResponse):
     """
 
     def render(self, content: Any) -> bytes:
-        assert orjson is not None, "orjson must be installed to use ORJSONResponse"
+        print("Inside the render my boi")
+        if orjson is None:
+            raise RuntimeError("orjson must be installed to use ORJSONResponse")
         return orjson.dumps(
             content, option=orjson.OPT_NON_STR_KEYS | orjson.OPT_SERIALIZE_NUMPY
         )

fastapi/routing.py

@@ -207,7 +207,8 @@ async def run_endpoint_function(
 ) -> Any:
     # Only called by get_request_handler. Has been split into its own function to
     # facilitate profiling endpoints, since inner functions are harder to profile.
-    assert dependant.call is not None, "dependant.call must be a function"
+    if dependant.call is None:
+        raise ValueError("dependant.call must be a callable function")
 
     if is_coroutine:
         return await dependant.call(**values)
@@ -230,7 +231,8 @@ def get_request_handler(
     dependency_overrides_provider: Optional[Any] = None,
     embed_body_fields: bool = False,
 ) -> Callable[[Request], Coroutine[Any, Any, Response]]:
-    assert dependant.call is not None, "dependant.call must be a function"
+    if dependant.call is None:
+        raise ValueError("dependant.call must be a callable function")
     is_coroutine = asyncio.iscoroutinefunction(dependant.call)
     is_body_form = body_field and isinstance(body_field.field_info, params.Form)
     if isinstance(response_class, DefaultPlaceholder):
@@ -380,7 +382,8 @@ def get_websocket_app(
                 raise WebSocketRequestValidationError(
                     _normalize_errors(solved_result.errors)
                 )
-            assert dependant.call is not None, "dependant.call must be a function"
+            if dependant.call is None:
+                raise ValueError("dependant.call must be a callable function")
             await dependant.call(**solved_result.values)
 
     return app
@@ -505,9 +508,10 @@ class APIRoute(routing.Route):
             status_code = int(status_code)
         self.status_code = status_code
         if self.response_model:
-            assert is_body_allowed_for_status_code(status_code), (
-                f"Status code {status_code} must not have a response body"
-            )
+            if not is_body_allowed_for_status_code(status_code):
+                raise ValueError(
+                    f"Status code {status_code} must not have a response body"
+                )
             response_name = "Response_" + self.unique_id
             self.response_field = create_model_field(
                 name=response_name,
@@ -535,12 +539,14 @@ class APIRoute(routing.Route):
         self.description = self.description.split("\f")[0].strip()
         response_fields = {}
         for additional_status_code, response in self.responses.items():
-            assert isinstance(response, dict), "An additional response must be a dict"
+            if not isinstance(response, dict):
+                raise TypeError("An additional response must be a dict")
             model = response.get("model")
             if model:
-                assert is_body_allowed_for_status_code(additional_status_code), (
-                    f"Status code {additional_status_code} must not have a response body"
-                )
+                if not is_body_allowed_for_status_code(status_code):
+                    raise ValueError(
+                        f"Status code {status_code} must not have a response body"
+                    )
                 response_name = f"Response_{additional_status_code}_{self.unique_id}"
                 response_field = create_model_field(
                     name=response_name, type_=model, mode="serialization"
@@ -551,7 +557,9 @@ class APIRoute(routing.Route):
         else:
             self.response_fields = {}
 
-        assert callable(endpoint), "An endpoint must be a callable"
+        if not callable(endpoint):
+            raise TypeError("An endpoint must be a callable")
+
         self.dependant = get_dependant(path=self.path_format, call=self.endpoint)
         for depends in self.dependencies[::-1]:
             self.dependant.dependencies.insert(
@@ -844,10 +852,13 @@ class APIRouter(routing.Router):
             lifespan=lifespan,
         )
         if prefix:
-            assert prefix.startswith("/"), "A path prefix must start with '/'"
-            assert not prefix.endswith("/"), (
-                "A path prefix must not end with '/', as the routes will start with '/'"
-            )
+            if not prefix.startswith("/"):
+                raise ValueError("A path prefix must start with '/'")
+            if prefix.endswith("/"):
+                raise ValueError(
+                    "A path prefix must not end with '/', as the routes will start with '/'"
+                )
+
         self.prefix = prefix
         self.tags: List[Union[str, Enum]] = tags or []
         self.dependencies = list(dependencies or [])
@@ -1256,10 +1267,13 @@ class APIRouter(routing.Router):
         ```
         """
         if prefix:
-            assert prefix.startswith("/"), "A path prefix must start with '/'"
-            assert not prefix.endswith("/"), (
-                "A path prefix must not end with '/', as the routes will start with '/'"
-            )
+            if not prefix.startswith("/"):
+                raise ValueError("A path prefix must start with '/'")
+            if prefix.endswith("/"):
+                raise ValueError(
+                    "A path prefix must not end with '/', as the routes will start with '/'"
+                )
+
         else:
             for r in router.routes:
                 path = getattr(r, "path")  # noqa: B009

fastapi/utils.py

@@ -177,9 +177,11 @@ def generate_operation_id_for_path(
 
 
 def generate_unique_id(route: "APIRoute") -> str:
+    if not route.methods:
+        raise ValueError("Route must have at least one HTTP method")
+
     operation_id = f"{route.name}{route.path_format}"
     operation_id = re.sub(r"\W", "_", operation_id)
-    assert route.methods
     operation_id = f"{operation_id}_{list(route.methods)[0].lower()}"
     return operation_id