From 318e73a301c96da2e1cc036b294c984632d47855 Mon Sep 17 00:00:00 2001 From: Postnov Roman Date: Sat, 5 Apr 2025 12:54:04 +0300 Subject: [PATCH] fix(tests): Dispose SQLAlchemy engine in client fixture teardown --- tests/test_tutorial/test_sql_databases/test_tutorial001.py | 2 ++ tests/test_tutorial/test_sql_databases/test_tutorial002.py | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tests/test_tutorial/test_sql_databases/test_tutorial001.py b/tests/test_tutorial/test_sql_databases/test_tutorial001.py index 2a1343503..6fcf09357 100644 --- a/tests/test_tutorial/test_sql_databases/test_tutorial001.py +++ b/tests/test_tutorial/test_sql_databases/test_tutorial001.py @@ -47,6 +47,8 @@ def get_client(request: pytest.FixtureRequest): with TestClient(mod.app) as c: yield c + mod.engine.dispose() + def test_crud_app(client: TestClient): # TODO: this warns that SQLModel.from_orm is deprecated in Pydantic v1, refactor diff --git a/tests/test_tutorial/test_sql_databases/test_tutorial002.py b/tests/test_tutorial/test_sql_databases/test_tutorial002.py index 19e0f98a5..2eb5a8b36 100644 --- a/tests/test_tutorial/test_sql_databases/test_tutorial002.py +++ b/tests/test_tutorial/test_sql_databases/test_tutorial002.py @@ -47,6 +47,8 @@ def get_client(request: pytest.FixtureRequest): with TestClient(mod.app) as c: yield c + mod.engine.dispose() + def test_crud_app(client: TestClient): # TODO: this warns that SQLModel.from_orm is deprecated in Pydantic v1, refactor