From 10fb7ace047e71616d8b0b1feaa996858d3f8b72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebasti=C3=A1n=20Ram=C3=ADrez?= Date: Sat, 4 Apr 2020 22:36:10 +0200 Subject: [PATCH] :memo: Update contributing guidelines to review translation PRs (#1215) --- docs/en/docs/contributing.md | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/docs/en/docs/contributing.md b/docs/en/docs/contributing.md index 57767f488..66fc8efc9 100644 --- a/docs/en/docs/contributing.md +++ b/docs/en/docs/contributing.md @@ -257,7 +257,16 @@ Here are the steps to help with translations. #### Tips and guidelines -* Add a single Pull Request per page translated. That will make it much easier for others to review it. +* Check the currently existing pull requests for your language and add reviews requesting changes or approving them. + +!!! tip + You can add comments with change suggestions to existing pull requests. + + Check the docs about adding a pull request review to approve it or request changes. + +* Check in the issues to see if there's one coordinating translations for your language. + +* Add a single pull request per page translated. That will make it much easier for others to review it. For the languages I don't speak, I'll wait for several others to review the translation before merging. @@ -385,6 +394,11 @@ Updating en Now you can check in your code editor the newly created directory `docs/ht/`. +!!! tip + Create a first pull request with just this, to set up the configuration for the new language, before adding translations. + + That way others can help with other pages while you work on the first one. 🚀 + Start by translating the main page, `docs/ht/index.md`. Then you can continue with the previous instructions, for an "Existing Language".