Correct capability flags for production modes

src/socketio/admin.py

@@ -147,8 +147,10 @@ class InstrumentedServer:
             self.sio.sleep(0.1)
 
             # supported features
-            features = ['EMIT', 'JOIN', 'LEAVE', 'DISCONNECT', 'MJOIN',
-                        'MLEAVE', 'MDISCONNECT', 'AGGREGATED_EVENTS']
+            features = ['AGGREGATED_EVENTS']
+            if not self.read_only:
+                features += ['EMIT', 'JOIN', 'LEAVE', 'DISCONNECT', 'MJOIN',
+                             'MLEAVE', 'MDISCONNECT']
             if self.mode == 'development':
                 features.append('ALL_EVENTS')
             self.sio.emit('config', {'supportedFeatures': features},

src/socketio/asyncio_admin.py

@@ -132,8 +132,10 @@ class InstrumentedAsyncServer:
             await self.sio.sleep(0.1)
 
             # supported features
-            features = ['EMIT', 'JOIN', 'LEAVE', 'DISCONNECT', 'MJOIN',
-                        'MLEAVE', 'MDISCONNECT', 'AGGREGATED_EVENTS']
+            features = ['AGGREGATED_EVENTS']
+            if not self.read_only:
+                features += ['EMIT', 'JOIN', 'LEAVE', 'DISCONNECT', 'MJOIN',
+                             'MLEAVE', 'MDISCONNECT']
             if self.mode == 'development':
                 features.append('ALL_EVENTS')
             await self.sio.emit('config', {'supportedFeatures': features},

tests/async/test_asyncio_admin.py

@@ -172,6 +172,8 @@ class TestAsyncAdmin(unittest.TestCase):
 
         assert 'supportedFeatures' in events['config']
         assert 'ALL_EVENTS' in events['config']['supportedFeatures']
+        assert 'AGGREGATED_EVENTS' in events['config']['supportedFeatures']
+        assert 'EMIT' in events['config']['supportedFeatures']
         assert len(events['all_sockets']) == 1
         assert events['all_sockets'][0]['id'] == sid
         assert events['all_sockets'][0]['rooms'] == [sid]
@@ -217,6 +219,8 @@ class TestAsyncAdmin(unittest.TestCase):
 
         assert 'supportedFeatures' in events['config']
         assert 'ALL_EVENTS' in events['config']['supportedFeatures']
+        assert 'AGGREGATED_EVENTS' in events['config']['supportedFeatures']
+        assert 'EMIT' in events['config']['supportedFeatures']
         assert len(events['all_sockets']) == 4
         assert events['server_stats']['clientsCount'] == 4
         assert events['server_stats']['pollingClientsCount'] == 1
@@ -238,7 +242,7 @@ class TestAsyncAdmin(unittest.TestCase):
             elif socket['id'] == sid3:
                 assert socket['rooms'] == [sid3]
 
-    @with_instrumented_server(mode='production')
+    @with_instrumented_server(mode='production', read_only=True)
     def test_admin_connect_production(self, isvr):
         with socketio.SimpleClient() as admin_client:
             admin_client.connect('http://localhost:8900', namespace='/admin')
@@ -252,6 +256,8 @@ class TestAsyncAdmin(unittest.TestCase):
 
         assert 'supportedFeatures' in events['config']
         assert 'ALL_EVENTS' not in events['config']['supportedFeatures']
+        assert 'AGGREGATED_EVENTS' in events['config']['supportedFeatures']
+        assert 'EMIT' not in events['config']['supportedFeatures']
         assert events['server_stats']['clientsCount'] == 1
         assert events['server_stats']['pollingClientsCount'] == 0
         assert len(events['server_stats']['namespaces']) == 3

tests/common/test_admin.py

@@ -150,6 +150,8 @@ class TestAdmin(unittest.TestCase):
 
         assert 'supportedFeatures' in events['config']
         assert 'ALL_EVENTS' in events['config']['supportedFeatures']
+        assert 'AGGREGATED_EVENTS' in events['config']['supportedFeatures']
+        assert 'EMIT' in events['config']['supportedFeatures']
         assert len(events['all_sockets']) == 1
         assert events['all_sockets'][0]['id'] == sid
         assert events['all_sockets'][0]['rooms'] == [sid]
@@ -195,6 +197,8 @@ class TestAdmin(unittest.TestCase):
 
         assert 'supportedFeatures' in events['config']
         assert 'ALL_EVENTS' in events['config']['supportedFeatures']
+        assert 'AGGREGATED_EVENTS' in events['config']['supportedFeatures']
+        assert 'EMIT' in events['config']['supportedFeatures']
         assert len(events['all_sockets']) == 4
         assert events['server_stats']['clientsCount'] == 4
         assert events['server_stats']['pollingClientsCount'] == 1
@@ -216,7 +220,7 @@ class TestAdmin(unittest.TestCase):
             elif socket['id'] == sid3:
                 assert socket['rooms'] == [sid3]
 
-    @with_instrumented_server(mode='production')
+    @with_instrumented_server(mode='production', read_only=True)
     def test_admin_connect_production(self, isvr):
         with socketio.SimpleClient() as admin_client:
             admin_client.connect('http://localhost:8900', namespace='/admin')
@@ -230,6 +234,8 @@ class TestAdmin(unittest.TestCase):
 
         assert 'supportedFeatures' in events['config']
         assert 'ALL_EVENTS' not in events['config']['supportedFeatures']
+        assert 'AGGREGATED_EVENTS' in events['config']['supportedFeatures']
+        assert 'EMIT' not in events['config']['supportedFeatures']
         assert events['server_stats']['clientsCount'] == 1
         assert events['server_stats']['pollingClientsCount'] == 0
         assert len(events['server_stats']['namespaces']) == 3