From b0518936b949f759f2be8da0cc7b9c30af440371 Mon Sep 17 00:00:00 2001 From: Andrei Neagu Date: Wed, 20 May 2020 18:53:52 +0200 Subject: [PATCH] AsyncPubSubManager does not await for can_disconnect (#488) --- socketio/asyncio_pubsub_manager.py | 2 +- tests/asyncio/test_asyncio_pubsub_manager.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/socketio/asyncio_pubsub_manager.py b/socketio/asyncio_pubsub_manager.py index cff1ff0..0e41f25 100644 --- a/socketio/asyncio_pubsub_manager.py +++ b/socketio/asyncio_pubsub_manager.py @@ -72,7 +72,7 @@ class AsyncPubSubManager(AsyncManager): async def can_disconnect(self, sid, namespace): if self.is_connected(sid, namespace): # client is in this server, so we can disconnect directly - return super().can_disconnect(sid, namespace) + return await super().can_disconnect(sid, namespace) else: # client is in another server, so we post request to the queue await self._publish({'method': 'disconnect', 'sid': sid, diff --git a/tests/asyncio/test_asyncio_pubsub_manager.py b/tests/asyncio/test_asyncio_pubsub_manager.py index 35bdba8..8248334 100644 --- a/tests/asyncio/test_asyncio_pubsub_manager.py +++ b/tests/asyncio/test_asyncio_pubsub_manager.py @@ -118,7 +118,7 @@ class TestAsyncPubSubManager(unittest.TestCase): def test_can_disconnect(self): self.pm.connect('123', '/') - self.assertTrue(_run(self.pm.can_disconnect('123', '/'))) + self.assertTrue(_run(self.pm.can_disconnect('123', '/')) is True) _run(self.pm.can_disconnect('123', '/foo')) self.pm._publish.mock.assert_called_once_with( {'method': 'disconnect', 'sid': '123', 'namespace': '/foo'})