From 6ae89688d72ec7f570a0b04a1bbf0483865bb5b5 Mon Sep 17 00:00:00 2001
From: Miguel Grinberg <miguelgrinberg50@gmail.com>
Date: Sun, 13 Dec 2015 16:35:52 -0800
Subject: [PATCH] do not allow callbacks outside of a server context

---
 socketio/pubsub_manager.py   | 3 +++
 tests/test_pubsub_manager.py | 5 +++++
 2 files changed, 8 insertions(+)

diff --git a/socketio/pubsub_manager.py b/socketio/pubsub_manager.py
index 48ca09f..c454540 100644
--- a/socketio/pubsub_manager.py
+++ b/socketio/pubsub_manager.py
@@ -46,6 +46,9 @@ class PubSubManager(BaseManager):
         """
         namespace = namespace or '/'
         if callback is not None:
+            if self.server is None:
+                raise RuntimeError('Callbacks can only be issued from the '
+                                   'context of a server.')
             if room is None:
                 raise ValueError('Cannot use callback without a room set.')
             id = self._generate_ack_id(room, namespace, callback)
diff --git a/tests/test_pubsub_manager.py b/tests/test_pubsub_manager.py
index 9fab1d7..0345eb2 100644
--- a/tests/test_pubsub_manager.py
+++ b/tests/test_pubsub_manager.py
@@ -66,6 +66,11 @@ class TestBaseManager(unittest.TestCase):
                  'namespace': '/', 'room': 'baz', 'skip_sid': None,
                  'callback': ('baz', '/', '123')})
 
+    def test_emit_with_callback_without_server(self):
+        standalone_pm = pubsub_manager.PubSubManager()
+        self.assertRaises(RuntimeError, standalone_pm.emit, 'foo', 'bar',
+                          callback='cb')
+
     def test_emit_with_callback_missing_room(self):
         with mock.patch.object(self.pm, '_generate_ack_id',
                                return_value='123'):