From 469b7c0dd51eea97979f784d0c94359ad18a96ac Mon Sep 17 00:00:00 2001
From: Miguel Grinberg <miguel.grinberg@gmail.com>
Date: Tue, 18 Jun 2024 23:38:53 +0100
Subject: [PATCH] Ignore catch-all namespace in client connections (Fixes
 #1351)

---
 src/socketio/async_client.py | 2 ++
 src/socketio/client.py       | 2 ++
 tests/async/test_client.py   | 1 +
 tests/common/test_client.py  | 1 +
 4 files changed, 6 insertions(+)

diff --git a/src/socketio/async_client.py b/src/socketio/async_client.py
index d7e8c27..41fadd6 100644
--- a/src/socketio/async_client.py
+++ b/src/socketio/async_client.py
@@ -128,6 +128,8 @@ class AsyncClient(base_client.BaseClient):
         if namespaces is None:
             namespaces = list(set(self.handlers.keys()).union(
                 set(self.namespace_handlers.keys())))
+            if '*' in namespaces:
+                namespaces.remove('*')
             if len(namespaces) == 0:
                 namespaces = ['/']
         elif isinstance(namespaces, str):
diff --git a/src/socketio/client.py b/src/socketio/client.py
index e5150e9..0e70ed7 100644
--- a/src/socketio/client.py
+++ b/src/socketio/client.py
@@ -126,6 +126,8 @@ class Client(base_client.BaseClient):
         if namespaces is None:
             namespaces = list(set(self.handlers.keys()).union(
                 set(self.namespace_handlers.keys())))
+            if '*' in namespaces:
+                namespaces.remove('*')
             if len(namespaces) == 0:
                 namespaces = ['/']
         elif isinstance(namespaces, str):
diff --git a/tests/async/test_client.py b/tests/async/test_client.py
index 82c66e1..cf99059 100644
--- a/tests/async/test_client.py
+++ b/tests/async/test_client.py
@@ -98,6 +98,7 @@ class TestAsyncClient(unittest.TestCase):
         c.eio.connect = AsyncMock()
         c.on('foo', mock.MagicMock(), namespace='/foo')
         c.on('bar', mock.MagicMock(), namespace='/')
+        c.on('baz', mock.MagicMock(), namespace='*')
         _run(
             c.connect(
                 'url',
diff --git a/tests/common/test_client.py b/tests/common/test_client.py
index eecad7d..52cfc33 100644
--- a/tests/common/test_client.py
+++ b/tests/common/test_client.py
@@ -236,6 +236,7 @@ class TestClient(unittest.TestCase):
         c.eio.connect = mock.MagicMock()
         c.on('foo', mock.MagicMock(), namespace='/foo')
         c.on('bar', mock.MagicMock(), namespace='/')
+        c.on('baz', mock.MagicMock(), namespace='*')
         c.connect(
             'url',
             headers='headers',