From 23556fb3dcb37074020494df40fb4495d47e7efe Mon Sep 17 00:00:00 2001 From: Miguel Grinberg Date: Mon, 29 Sep 2025 07:32:12 +0100 Subject: [PATCH] Fixed transport property of the simple clients to be a string as documented (Fixes #1499) --- src/socketio/async_simple_client.py | 2 +- src/socketio/simple_client.py | 2 +- tests/async/test_simple_client.py | 2 +- tests/common/test_simple_client.py | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/socketio/async_simple_client.py b/src/socketio/async_simple_client.py index adac6ea..6142522 100644 --- a/src/socketio/async_simple_client.py +++ b/src/socketio/async_simple_client.py @@ -105,7 +105,7 @@ class AsyncSimpleClient: The transport is returned as a string and can be one of ``polling`` and ``websocket``. """ - return self.client.transport if self.client else '' + return self.client.transport() if self.client else '' async def emit(self, event, data=None): """Emit an event to the server. diff --git a/src/socketio/simple_client.py b/src/socketio/simple_client.py index 3f046b4..9bc5390 100644 --- a/src/socketio/simple_client.py +++ b/src/socketio/simple_client.py @@ -103,7 +103,7 @@ class SimpleClient: The transport is returned as a string and can be one of ``polling`` and ``websocket``. """ - return self.client.transport if self.client else '' + return self.client.transport() if self.client else '' def emit(self, event, data=None): """Emit an event to the server. diff --git a/tests/async/test_simple_client.py b/tests/async/test_simple_client.py index bfe2a90..0f3e504 100644 --- a/tests/async/test_simple_client.py +++ b/tests/async/test_simple_client.py @@ -72,7 +72,7 @@ class TestAsyncAsyncSimpleClient: async def test_properties(self): client = AsyncSimpleClient() - client.client = mock.MagicMock(transport='websocket') + client.client = mock.MagicMock(transport=lambda: 'websocket') client.client.get_sid.return_value = 'sid' client.connected_event.set() client.connected = True diff --git a/tests/common/test_simple_client.py b/tests/common/test_simple_client.py index b17afbc..6adcb38 100644 --- a/tests/common/test_simple_client.py +++ b/tests/common/test_simple_client.py @@ -64,7 +64,7 @@ class TestSimpleClient: def test_properties(self): client = SimpleClient() - client.client = mock.MagicMock(transport='websocket') + client.client = mock.MagicMock(transport=lambda: 'websocket') client.client.get_sid.return_value = 'sid' client.connected_event.set() client.connected = True