From a7a448cbcde8379dbafc1b8d7beb552671503ac1 Mon Sep 17 00:00:00 2001 From: Dan Ditomaso Date: Fri, 21 Mar 2025 23:34:20 -0400 Subject: [PATCH] refactor: improved how reminder expiry dates are handled. --- src/core/hooks/useKeyBackupReminder.tsx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/core/hooks/useKeyBackupReminder.tsx b/src/core/hooks/useKeyBackupReminder.tsx index 1669c429..3cc46842 100644 --- a/src/core/hooks/useKeyBackupReminder.tsx +++ b/src/core/hooks/useKeyBackupReminder.tsx @@ -24,7 +24,10 @@ const STORAGE_KEY = "key_backup_reminder"; function isReminderExpired(expires?: string): boolean { if (!expires) return true; const expiryDate = new Date(expires); - return isNaN(expiryDate.getTime()) || new Date() >= expiryDate; + if (isNaN(expiryDate.getTime())) return true; // Invalid date passed + + const now = new Date(); + return now.getTime() >= expiryDate.getTime(); } export function useBackupReminder({ @@ -70,7 +73,7 @@ export function useBackupReminder({ setReminderExpiry(reminderInDays); }} > - Remind me in {reminderInDays} days + Remind me in {reminderInDays} day{reminderInDays > 1 ? 's' : ''}