Browse Source

Review fixes

pull/790/head
philon- 11 months ago
parent
commit
9927fe80d4
  1. 4
      packages/transport-http/src/transport.ts
  2. 3
      packages/transport-web-bluetooth/src/transport.ts
  3. 2
      packages/transport-web-serial/src/transport.test.ts

4
packages/transport-http/src/transport.ts

@ -2,6 +2,7 @@ import { Types } from "@meshtastic/core";
const FETCH_INTERVAL_MS = 3000;
const READ_TIMEOUT_MS = 7000;
const READ_TIMEOUT_BUFFER_MS = 250;
const WRITE_TIMEOUT_MS = 4000;
function toArrayBuffer(uint8array: Uint8Array): ArrayBuffer {
@ -134,7 +135,8 @@ export class TransportHTTP implements Types.Transport {
if (this.fetching) {
if (
this._inflightReadController &&
Date.now() - this._inflightReadStartedAt > READ_TIMEOUT_MS + 250
Date.now() - this._inflightReadStartedAt >
READ_TIMEOUT_MS + READ_TIMEOUT_BUFFER_MS
) {
try {
this._inflightReadController.abort();

3
packages/transport-web-bluetooth/src/transport.ts

@ -223,8 +223,9 @@ export class TransportWebBluetooth implements Types.Transport {
data: new Uint8Array(value.buffer),
});
}
} catch {
} catch (error) {
this.emitStatus(Types.DeviceStatusEnum.DeviceDisconnected, "read-error");
throw error;
}
}

2
packages/transport-web-serial/src/transport.test.ts

@ -40,8 +40,6 @@ function stubCoreTransforms() {
};
}
type SerialDisconnectHandler = (ev: { port?: any }) => void;
function stubNavigatorSerial() {
type SerialDisconnectHandler = (ev: { port?: any }) => void;
const handlers = new Set<SerialDisconnectHandler>();

Loading…
Cancel
Save