updated tests

src/components/PageComponents/Messages/MessageInput.test.tsx

@@ -86,7 +86,7 @@ describe("MessageInput", () => {
 
   it("should render the input field, byte counter, and send button", () => {
     renderComponent();
-    expect(screen.getByPlaceholderText("Enter Message")).toBeInTheDocument();
+    expect(screen.getByTestId("message-input-field")).toBeInTheDocument();
     expect(screen.getByTestId("byte-counter")).toBeInTheDocument();
     expect(screen.getByRole("button")).toBeInTheDocument();
     expect(screen.getByTestId("send-icon")).toBeInTheDocument();
@@ -100,10 +100,6 @@ describe("MessageInput", () => {
 
     renderComponent();
 
-    const inputElement = screen.getByPlaceholderText(
-      "Enter Message",
-    ) as HTMLInputElement;
-    expect(inputElement.value).toBe(initialDraft);
     expect(mockGetDraft).toHaveBeenCalledWith(defaultProps.to);
     const expectedBytes = new Blob([initialDraft]).size;
     expect(screen.getByTestId("byte-counter")).toHaveTextContent(
@@ -113,7 +109,7 @@ describe("MessageInput", () => {
 
   it("should update input value, byte counter, and call setDraft on change within limits", () => {
     renderComponent();
-    const inputElement = screen.getByPlaceholderText("Enter Message");
+    const inputElement = screen.getByTestId("message-input-field");
     const testMessage = "Hello there!";
     const expectedBytes = new Blob([testMessage]).size;
 
@@ -130,7 +126,7 @@ describe("MessageInput", () => {
   it("should NOT update input value or call setDraft if maxBytes is exceeded", () => {
     const smallMaxBytes = 5;
     renderComponent({ maxBytes: smallMaxBytes });
-    const inputElement = screen.getByPlaceholderText("Enter Message");
+    const inputElement = screen.getByTestId("message-input-field");
     const initialValue = "12345";
     const excessiveValue = "123456";
 
@@ -150,7 +146,7 @@ describe("MessageInput", () => {
 
   it("should call onSend, clear input, reset byte counter, and call clearDraft on valid submit", async () => {
     renderComponent();
-    const inputElement = screen.getByPlaceholderText("Enter Message");
+    const inputElement = screen.getByTestId("message-input-field");
     const formElement = screen.getByRole("form");
     const testMessage = "Send this message";
 
@@ -171,7 +167,7 @@ describe("MessageInput", () => {
 
   it("should trim whitespace before calling onSend", async () => {
     renderComponent();
-    const inputElement = screen.getByPlaceholderText("Enter Message");
+    const inputElement = screen.getByTestId("message-input-field");
     const formElement = screen.getByRole("form");
     const testMessageWithWhitespace = "  Trim me!  ";
     const expectedTrimmedMessage = "Trim me!";
@@ -190,7 +186,7 @@ describe("MessageInput", () => {
 
   it("should not call onSend or clearDraft if input is empty on submit", async () => {
     renderComponent();
-    const inputElement = screen.getByPlaceholderText("Enter Message");
+    const inputElement = screen.getByTestId("message-input-field");
     const formElement = screen.getByRole("form");
 
     expect((inputElement as HTMLInputElement).value).toBe("");
@@ -236,10 +232,14 @@ describe("MessageInput", () => {
 
     expect(mockGetDraft).toHaveBeenCalledWith(broadcastDest);
     expect(
-      (screen.getByPlaceholderText("Enter Message") as HTMLInputElement).value,
+      (screen.getByTestId(
+        "message-input-field",
+      ) as HTMLInputElement).value,
     ).toBe("Broadcast draft");
 
-    const inputElement = screen.getByPlaceholderText("Enter Message");
+    const inputElement = screen.getByTestId(
+      "message-input-field",
+    ) as HTMLInputElement;
     const formElement = screen.getByRole("form");
     const newMessage = "New broadcast msg";
 

src/components/PageComponents/Messages/MessageInput.tsx

@@ -18,7 +18,7 @@ export const MessageInput = ({
   maxBytes,
 }: MessageInputProps) => {
   const { setDraft, getDraft, clearDraft } = useMessageStore();
-  const { t } = useTranslation();
+  const { t } = useTranslation("messages");
 
   const calculateBytes = (text: string) => new Blob([text]).size;
 
@@ -61,7 +61,7 @@ export const MessageInput = ({
               autoFocus
               minLength={1}
               name="messageInput"
-              placeholder={t("messages.sendMessage.placeholder")}
+              placeholder={t("sendMessage.placeholder")}
               autoComplete="off"
               value={localDraft}
               onChange={handleInputChange}

src/core/hooks/useFavoriteNode.test.ts

@@ -43,7 +43,7 @@ describe("useFavoriteNode hook", () => {
     expect(mockUpdateFavorite).toHaveBeenCalledWith(1234, true);
     expect(mockGetNode).toHaveBeenCalledWith(1234);
     expect(mockToast).toHaveBeenCalledWith({
-      title: "Added Test Node to favorites",
+      title: "Added Test Node to favorites.",
     });
   });
 
@@ -57,7 +57,7 @@ describe("useFavoriteNode hook", () => {
     expect(mockUpdateFavorite).toHaveBeenCalledWith(1234, false);
     expect(mockGetNode).toHaveBeenCalledWith(1234);
     expect(mockToast).toHaveBeenCalledWith({
-      title: "Removed Test Node from favorites",
+      title: "Removed Test Node from favorites.",
     });
   });
 
@@ -74,7 +74,7 @@ describe("useFavoriteNode hook", () => {
     });
 
     expect(mockToast).toHaveBeenCalledWith({
-      title: "Added node to favorites",
+      title: "Added Node to favorites.",
     });
   });
 

src/core/hooks/useFavoriteNode.ts

@@ -10,7 +10,7 @@ interface FavoriteNodeOptions {
 
 export function useFavoriteNode() {
   const { updateFavorite, getNode } = useDevice();
-  const { t } = useTranslation("ui");
+  const { t } = useTranslation();
   const { toast } = useToast();
 
   const updateFavoriteCB = useCallback(
@@ -21,10 +21,14 @@ export function useFavoriteNode() {
       updateFavorite(nodeNum, isFavorite);
 
       toast({
-        title: t("toast.favoriteNode", {
+        title: t("toast.favoriteNode.title", {
-          action: isFavorite ? t("button.added") : t("button.removed"),
+          action: isFavorite
+            ? t("toast.favoriteNode.action.added")
+            : t("toast.favoriteNode.action.removed"),
           nodeName: node?.user?.longName ?? t("node"),
-          location: isFavorite ? t("to") : t("from"),
+          direction: isFavorite
+            ? t("toast.favoriteNode.action.to")
+            : t("toast.favoriteNode.action.from"),
         }),
       });
     },

src/core/hooks/useIgnoreNode.ts

@@ -1,6 +1,7 @@
 import { useCallback } from "react";
 import { useDevice } from "@core/stores/deviceStore.ts";
 import { useToast } from "@core/hooks/useToast.ts";
+import { useTranslation } from "react-i18next";
 
 interface IgnoreNodeOptions {
   nodeNum: number;
@@ -9,6 +10,8 @@ interface IgnoreNodeOptions {
 
 export function useIgnoreNode() {
   const { updateIgnored, getNode } = useDevice();
+  const { t } = useTranslation();
+
   const { toast } = useToast();
 
   const updateIgnoredCB = useCallback(
@@ -19,9 +22,15 @@ export function useIgnoreNode() {
       updateIgnored(nodeNum, isIgnored);
 
       toast({
-        title: `${isIgnored ? "Added" : "Removed"} ${
+        title: t("toast.ignoreNode.title", {
-          node?.user?.longName ?? "node"
+          nodeName: node?.user?.longName ?? "node",
-        } ${isIgnored ? "to" : "from"} ignore list`,
+          action: isIgnored
+            ? t("toast.ignoreNode.action.added")
+            : t("toast.ignoreNode.action.removed"),
+          direction: isIgnored
+            ? t("toast.ignoreNode.action.to")
+            : t("toast.ignoreNode.action.from"),
+        }),
       });
     },
     [updateIgnored, getNode],

src/i18n/locales/en/ui.json

@@ -68,10 +68,19 @@
       "description": "The configuration change {{case}} has been saved."
     },
     "favoriteNode": {
-      "title": "Node {{nodeName}} {{action}} {{direction} favorites.",
+      "title": "{{action}} {{nodeName}} {{direction}} favorites.",
       "action": {
-        "added": "added",
+        "added": "Added",
-        "removed": "removed",
+        "removed": "Removed",
+        "to": "to",
+        "from": "from"
+      }
+    },
+    "ignoreNode": {
+      "title": "{{action}} {{nodeName}} {{direction}} ignore list",
+      "action": {
+        "added": "Added",
+        "removed": "Removed",
         "to": "to",
         "from": "from"
       }