fix #271: code bugs detected by sonarcloud

steam/client/builtins/gameservers.py

@@ -40,6 +40,7 @@ from steam.enums import EResult
 from steam.enums.emsg import EMsg
 from steam.utils import ip_to_int, ip_from_int
 from steam.utils.proto import proto_to_dict
+from steam.exceptions import SteamError
 
 
 class GameServers(object):

steam/core/manifest.py

@@ -180,7 +180,7 @@ class DepotManifest(object):
             try:
                 filename = symmetric_decrypt(filename, depot_key)
             except Exception:
-                RuntimeError("Unable to decrypt filename for depot manifest")
+                raise RuntimeError("Unable to decrypt filename for depot manifest")
 
             mapping.filename = filename
 

steam/webapi.py

@@ -397,7 +397,7 @@ def webapi_request(url, method='GET', caller=None, session=None, params=None):
     :rtype: :class:`dict`, :class:`lxml.etree.Element`, :class:`str`
     """
     if method not in ('GET', 'POST'):
-        raise NotImplemented("HTTP method: %s" % repr(self.method))
+        raise ValueError("Only GET and POST methods are supported, got: %s" % repr(method))
     if params is None:
         params = {}
 

steam/webauth.py

@@ -230,8 +230,6 @@ class WebAuth(object):
                 self.password = ''
                 raise LoginIncorrect(resp['message'])
 
-        return None
-
     def cli_login(self, password='', captcha='', email_code='', twofactor_code='', language='english'):
         """Generates CLI prompts to perform the entire login process
 

tests/test_steamid.py

@@ -185,7 +185,7 @@ class SteamID_initialization(unittest.TestCase):
 class SteamID_properties(unittest.TestCase):
     def test_repr(self):
         # just to cover in coverage
-        repr(SteamID())
+        self.assertTrue('SteamID' in repr(SteamID()))
 
     def test_is_valid(self):
         # default