Every thread now has a name and either a contextually relevant
identifier or their in hex to disambiguate multiple threads of the same
type. Also finally gets rid of that old python 2 style init call.
As it is a required parameter.
Don't unnecessarily send a second SPEAKING payload after
connecting to voice
We do need to send a SPEAKING payload in order to set our SSRC value
after connecting to voice, yet that can be with a `state` of 0
(SpeakingState.none).
There is no reason to send 2 packets; one marking ourselves as
speaking, and then not speaking.
Some of the logs were only useful for debug scenarios, so they have
been downgraded to DEBUG. Others were in INFO but supposed to be in
WARNING so those were upgraded.
Segments where readability was hampered were fixed by appropriate
format skipping directives. New code should hopefully be black
compatible. The moment they remove the -S option is probably the moment
I stop using black though.
The difference in speed seems negligible at start up, which is when
most time is taken for actually parsing JSON. I could potentially be
missing something but profiling didn't point to any discernable
difference.
Not overly proud of this implementation but this allows the library
to differentiate between a 4014 that means "move to another channel" or
"move nowhere". Sometimes the VOICE_STATE_UPDATE comes before the
actual websocket disconnect so special care had to be taken in that
case.
Fix#5904
The previous code would check zombie connections depending on whether
HEARTBEAT_ACK was received. Unfortunately when there's exceeding
backpressure the connection can terminate since the HEARTBEAT_ACK is
buffered very far away despite it being there, just not received yet.
Andrin
Imayhaveborkedit
Rapptz
Andrew Morgan
Florian Spieß
Bryan Forbes
Lilly Rose Berner
Kellen
jack1142
Stocker
Predä
Josh
Aaron Hennessey
apple502j
Nadir Chowdhury
Riley Shaw
Nihaal Sangha