From a2b053a517fe52597bc84b91a7359fb20042b1da Mon Sep 17 00:00:00 2001 From: Rapptz Date: Thu, 30 Jun 2016 15:15:49 -0400 Subject: [PATCH] [commands] Make GroupMixin.remove_command return None. This is for cases where the command has been removed already. This will make the function have a somewhat no exception guarantee. --- discord/ext/commands/core.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/discord/ext/commands/core.py b/discord/ext/commands/core.py index 9308e9ce2..9abee04e6 100644 --- a/discord/ext/commands/core.py +++ b/discord/ext/commands/core.py @@ -486,6 +486,11 @@ class GroupMixin: `None` is returned instead. """ command = self.commands.pop(name, None) + + # does not exist + if command is None: + return None + if name in command.aliases: # we're removing an alias so we don't want to remove the rest return command