From 6f3bd7c0e6b4a4984290b4cbd5ce4a63c695c2f3 Mon Sep 17 00:00:00 2001 From: Rapptz Date: Mon, 4 Jul 2016 08:01:57 -0400 Subject: [PATCH] Fix issue with removing roles out of order. Fixes #250. --- discord/client.py | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/discord/client.py b/discord/client.py index 3a2ef8fbe..59c19d318 100644 --- a/discord/client.py +++ b/discord/client.py @@ -2348,16 +2348,11 @@ class Client: Removing roles failed. """ new_roles = [x.id for x in member.roles] - remove = [] for role in roles: try: - index = new_roles.index(role.id) - remove.append(index) + new_roles.remove(role.id) except ValueError: - continue - - for index in reversed(remove): - del new_roles[index] + pass yield from self._replace_roles(member, new_roles)