From 5e6491c3fedf2b23e6e1593f473ca4d30d61179c Mon Sep 17 00:00:00 2001 From: Rapptz Date: Thu, 1 Jun 2017 03:32:18 -0400 Subject: [PATCH] [commands] Allow inline advanced converters via classmethods. That way you don't need to have, e.g. Foo and FooConverter and can do it inline via Foo instead. --- discord/ext/commands/core.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/discord/ext/commands/core.py b/discord/ext/commands/core.py index 3655deafd..4c541f41b 100644 --- a/discord/ext/commands/core.py +++ b/discord/ext/commands/core.py @@ -204,10 +204,16 @@ class Command: if converter.__module__.startswith('discord.') and not converter.__module__.endswith('converter'): converter = getattr(converters, converter.__name__ + 'Converter') - if inspect.isclass(converter) and issubclass(converter, converters.Converter): - instance = converter() - ret = yield from instance.convert(ctx, argument) - return ret + if inspect.isclass(converter): + if issubclass(converter, converters.Converter): + instance = converter() + ret = yield from instance.convert(ctx, argument) + return ret + else: + method = getattr(converter, 'convert', None) + if method is not None and inspect.ismethod(method): + ret = yield from method(ctx, argument) + return ret elif isinstance(converter, converters.Converter): ret = yield from converter.convert(ctx, argument) return ret