From 4aecdea0524e7b481f9750166bf9e9be287ec445 Mon Sep 17 00:00:00 2001 From: Rapptz Date: Fri, 20 Jul 2018 04:17:28 -0400 Subject: [PATCH] Make TextChannel.create_webhook name parameter mandatory. --- discord/channel.py | 9 +++------ discord/http.py | 8 ++++---- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/discord/channel.py b/discord/channel.py index 27b6301e0..a79b3424e 100644 --- a/discord/channel.py +++ b/discord/channel.py @@ -340,7 +340,7 @@ class TextChannel(discord.abc.Messageable, discord.abc.GuildChannel, Hashable): data = await self._state.http.channel_webhooks(self.id) return [Webhook.from_state(d, state=self._state) for d in data] - async def create_webhook(self, *, name=None, avatar=None): + async def create_webhook(self, *, name, avatar=None): """|coro| Creates a webhook for this channel. @@ -349,7 +349,7 @@ class TextChannel(discord.abc.Messageable, discord.abc.GuildChannel, Hashable): Parameters ------------- - name: Optional[str] + name: str The webhook's name. avatar: Optional[bytes] A *bytes-like* object representing the webhook's default avatar. @@ -371,10 +371,7 @@ class TextChannel(discord.abc.Messageable, discord.abc.GuildChannel, Hashable): if avatar is not None: avatar = utils._bytes_to_base64_data(avatar) - if name is not None: - name = str(name) - - data = await self._state.http.create_webhook(self.id, name=name, avatar=avatar) + data = await self._state.http.create_webhook(self.id, name=str(name), avatar=avatar) return Webhook.from_state(data, state=self._state) class VoiceChannel(discord.abc.Connectable, discord.abc.GuildChannel, Hashable): diff --git a/discord/http.py b/discord/http.py index de8b6b0d8..d5b8423e7 100644 --- a/discord/http.py +++ b/discord/http.py @@ -529,10 +529,10 @@ class HTTPClient: # Webhook management - def create_webhook(self, channel_id, *, name=None, avatar=None): - payload = {} - if name is not None: - payload['name'] = name + def create_webhook(self, channel_id, *, name, avatar=None): + payload = { + 'name': name + } if avatar is not None: payload['avatar'] = avatar