From 49a7e58d17de0fb519f0dc4636f40f3b3526ed6d Mon Sep 17 00:00:00 2001 From: Rapptz Date: Sun, 12 May 2019 01:31:09 -0400 Subject: [PATCH] [tasks] Keep retrying before gracefully exiting. --- discord/ext/tasks/__init__.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/discord/ext/tasks/__init__.py b/discord/ext/tasks/__init__.py index 7b2afaceb..ad52f549a 100644 --- a/discord/ext/tasks/__init__.py +++ b/discord/ext/tasks/__init__.py @@ -74,8 +74,6 @@ class Loop: except self._valid_exception as exc: if not self.reconnect: raise - if self._stop_next_iteration: - return await asyncio.sleep(backoff.delay()) else: if self._stop_next_iteration: @@ -141,6 +139,16 @@ class Loop: Unlike :meth:`cancel`\, this allows the task to finish its current iteration before gracefully exiting. + .. note:: + + If the internal function raises an error that can be + handled before finishing then it will retry until + it succeeds. + + If this is undesirable, either remove the error handling + before stopping via :meth:`clear_exception_types` or + use :meth:`cancel` instead. + .. versionadded:: 1.2 """ if self._task and not self._task.done():