From 34fd266cf9e743d72603c9a73f3fff29fcb9d6e8 Mon Sep 17 00:00:00 2001 From: Hornwitser Date: Tue, 31 Jul 2018 18:19:43 +0200 Subject: [PATCH] [lint] Do log formating lazily Convert log("fmt" % args) to log("fmt", args) as the latter is lazy and does not do the formating if the string is never logged. --- discord/gateway.py | 4 ++-- discord/opus.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/discord/gateway.py b/discord/gateway.py index 7e297d4f5..a8c8ee24d 100644 --- a/discord/gateway.py +++ b/discord/gateway.py @@ -70,7 +70,7 @@ class KeepAliveHandler(threading.Thread): def run(self): while not self._stop_ev.wait(self.interval): if self._last_ack + self.heartbeat_timeout < time.perf_counter(): - log.warning("Shard ID %s has stopped responding to the gateway. Closing and restarting." % self.shard_id) + log.warning("Shard ID %s has stopped responding to the gateway. Closing and restarting.", self.shard_id) coro = self.ws.close(4000) f = asyncio.run_coroutine_threadsafe(coro, loop=self.ws.loop) @@ -370,7 +370,7 @@ class DiscordWebSocket(websockets.client.WebSocketClientProtocol): self.sequence = None self.session_id = None - log.info('Shard ID %s session has been invalidated.' % self.shard_id) + log.info('Shard ID %s session has been invalidated.', self.shard_id) await self.identify() return diff --git a/discord/opus.py b/discord/opus.py index 36a178a7c..175867cd8 100644 --- a/discord/opus.py +++ b/discord/opus.py @@ -44,14 +44,14 @@ EncoderStructPtr = ctypes.POINTER(EncoderStruct) def _err_lt(result, func, args): if result < 0: - log.info('error has happened in {0.__name__}'.format(func)) + log.info('error has happened in %s', func.__name__) raise OpusError(result) return result def _err_ne(result, func, args): ret = args[-1]._obj if ret.value != 0: - log.info('error has happened in {0.__name__}'.format(func)) + log.info('error has happened in %s', func.__name__) raise OpusError(ret.value) return result