Browse Source

Don't assume that any shared fields are optional in Client.edit_channel.

Thanks Jake and night.
pull/146/merge
Rapptz 9 years ago
parent
commit
2ebc0ab218
  1. 6
      discord/client.py
  2. 2
      discord/http.py

6
discord/client.py

@ -1522,8 +1522,10 @@ class Client:
Editing the channel failed.
"""
if 'name' not in options:
options['name'] = channel.name
keys = ('name', 'topic', 'position')
for key in keys:
if key not in options:
options[key] = getattr(channel, key)
yield from self.http.edit_channel(channel.id, **options)

2
discord/http.py

@ -339,7 +339,7 @@ class HTTPClient:
def edit_channel(self, channel_id, **options):
url = '{0.CHANNELS}/{1}'.format(self, channel_id)
valid_keys = ('name', 'topic', 'bitrate', 'user_limit')
valid_keys = ('name', 'topic', 'bitrate', 'user_limit', 'position')
payload = {
k: v for k, v in options.items() if k in valid_keys
}

Loading…
Cancel
Save