From 2938d0cfcf7c6b6aef5a35768a25501e519f29a9 Mon Sep 17 00:00:00 2001 From: Rapptz Date: Sat, 24 Oct 2015 23:36:12 -0400 Subject: [PATCH] Don't update member.roles in add/remove_roles. --- discord/client.py | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/discord/client.py b/discord/client.py index 25c7137d1..137ebee4f 100644 --- a/discord/client.py +++ b/discord/client.py @@ -1139,11 +1139,7 @@ class Client(object): response = requests.patch(url, headers=self.headers, json=payload) log.debug(request_logging_format.format(response=response, name='add_roles')) - if is_response_successful(response): - member.roles = list(itertools.chain(member.roles, roles)) - return True - - return False + return is_response_successful(response) def remove_roles(self, member, *roles): """Removes the :class:`Role` s from the :class:`Member`. @@ -1168,15 +1164,7 @@ class Client(object): response = requests.patch(url, headers=self.headers, json=payload) log.debug(request_logging_format.format(response=response, name='remove_roles')) - if is_response_successful(response): - member.roles = [] - for role in member.server.roles: - if role.id in new_roles: - member.roles.append(role) - - return True - - return False + return is_response_successful(response) def replace_roles(self, member, *roles): """Replaces the :class:`Member`'s roles.