Browse Source

Improve PR template and format JavaScript code

pull/10137/head
nkjh104 4 weeks ago
committed by GitHub
parent
commit
145ac6db3e
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 4
      .github/PULL_REQUEST_TEMPLATE.md
  2. 6
      .github/workflows/scripts/close_and_reopen_pr.js

4
.github/PULL_REQUEST_TEMPLATE.md

@ -2,13 +2,17 @@
<!-- What is this pull request for? Does it fix any issues? --> <!-- What is this pull request for? Does it fix any issues? -->
## Checklist ## Checklist
<!-- Put an x inside [ ] to check it, like so: [x] --> <!-- Put an x inside [ ] to check it, like so: [x] -->
- [ ] If code changes were made then they have been tested. - [ ] If code changes were made then they have been tested.
- [ ] I have updated the documentation to reflect the changes. - [ ] I have updated the documentation to reflect the changes.
- [ ] I have added tests that prove my fix is effective or that my feature works.
- [ ] This PR fixes an issue. - [ ] This PR fixes an issue.
- [ ] This PR adds something new (e.g. new method or parameters). - [ ] This PR adds something new (e.g. new method or parameters).
- [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed) - [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
- [ ] This PR is **not** a code change (e.g. documentation, README, ...) - [ ] This PR is **not** a code change (e.g. documentation, README, ...)
- [ ] I have ensured that my code follows the style guidelines of this project.

6
.github/workflows/scripts/close_and_reopen_pr.js

@ -1,4 +1,4 @@
module.exports = (async function ({github, context}) { module.exports = (async function ({ github, context }) {
const pr_number = process.env.PR_NUMBER; const pr_number = process.env.PR_NUMBER;
const pr_operation = process.env.PR_OPERATION; const pr_operation = process.env.PR_OPERATION;
@ -12,8 +12,8 @@ module.exports = (async function ({github, context}) {
await new Promise(r => setTimeout(r, 5000)); await new Promise(r => setTimeout(r, 5000));
// Close the PR // Close the PR
github.issues.update({ await github.pulls.update({
issue_number: pr_number, pull_number: pr_number,
owner: context.repo.owner, owner: context.repo.owner,
repo: context.repo.repo, repo: context.repo.repo,
state state

Loading…
Cancel
Save