MeshCore

3067 Commits

11 Branches

98 Tags

219 MiB

Tree: 47e1ce5bae

Commit Graph

Author	SHA1	Message	Date
Christoph Koehler	4f701b7aec	refactor: split MeshTables::hasSeen into pure query + markSeen hasSeen() was simultaneously a predicate and a mutator — it inserted the packet hash on every miss, making five call sites that only wanted to mark a packet as sent call it with the return value discarded. Split into: - wasSeen() — pure predicate, no side effects - markSeen() — explicit insert All query sites now call markSeen() immediately after wasSeen() returns false, preserving identical runtime behaviour. The five mark-only send sites (sendFlood, sendDirect, sendZeroHop x2) now call markSeen directly. Also fixes three bridge sites (BridgeBase, ESPNowBridge, RS232Bridge) that had the same query+implicit-insert pattern. Tests: add test/test_mesh_tables/ covering wasSeen purity, markSeen, dup stats, and clear. Update SHA256 mock to produce deterministic output (previously finalize() was a no-op). Add Packet.cpp to native build filter.	3 weeks ago
Michael Lynch	5e03c00397	Add unit tests for Utils::toHex	9 months ago

Author

SHA1

Message

Date

Christoph Koehler

4f701b7aec

refactor: split MeshTables::hasSeen into pure query + markSeen

hasSeen() was simultaneously a predicate and a mutator — it inserted the
packet hash on every miss, making five call sites that only wanted to mark
a packet as sent call it with the return value discarded.

Split into:
- wasSeen()   — pure predicate, no side effects
- markSeen()  — explicit insert

All query sites now call markSeen() immediately after wasSeen() returns
false, preserving identical runtime behaviour. The five mark-only send
sites (sendFlood, sendDirect, sendZeroHop x2) now call markSeen directly.

Also fixes three bridge sites (BridgeBase, ESPNowBridge, RS232Bridge)
that had the same query+implicit-insert pattern.

Tests: add test/test_mesh_tables/ covering wasSeen purity, markSeen,
dup stats, and clear. Update SHA256 mock to produce deterministic output
(previously finalize() was a no-op). Add Packet.cpp to native build filter.

3 weeks ago

Michael Lynch

5e03c00397

Add unit tests for Utils::toHex

9 months ago

2 Commits (47e1ce5bae10f4e1f54fcdf4bbfecec7a31fc8ac)