Browse Source

Refines buzzer melody buffer comment

Simplifies the explanation for using a static buffer for buzzer melodies.
pull/2665/head
Mark Jocas 2 months ago
parent
commit
256bce0482
No known key found for this signature in database GPG Key ID: F75EF1C43FC564B4
  1. 4
      src/helpers/ui/buzzer.cpp

4
src/helpers/ui/buzzer.cpp

@ -49,9 +49,7 @@ void genericBuzzer::playToggle(int count, bool enabled) {
const int max_notes = (int)(sizeof(notes) / sizeof(notes[0]));
if (count < 1) count = 1;
if (count > max_notes) count = max_notes;
// NonBlockingRtttl stores only a pointer to the melody, so the backing
// buffer must outlive the call. A static buffer is fine here because the
// library can't play two melodies at once anyway.
A static buffer as the library can't play two melodies at once anyway.
static char melody[64];
int n = snprintf(melody, sizeof(melody), "Tg:d=8,o=6,b=180:");
for (int i = 0; i < count && n < (int)sizeof(melody); i++) {

Loading…
Cancel
Save