Browse Source

Also fix countBefore(0xFFFFFFFF) to return _num

The signed comparison in countBefore breaks for the max uint32_t value.
Even though callers now use getOutboundTotal(), the function itself
should be correct for all inputs.
pull/1877/head
Daniel Novak 3 months ago
parent
commit
0d87dcc989
  1. 2
      src/helpers/StaticPoolPacketManager.cpp

2
src/helpers/StaticPoolPacketManager.cpp

@ -9,6 +9,8 @@ PacketQueue::PacketQueue(int max_entries) {
}
int PacketQueue::countBefore(uint32_t now) const {
if (now == 0xFFFFFFFF) return _num; // sentinel: count all entries regardless of schedule
int n = 0;
for (int j = 0; j < _num; j++) {
if ((int32_t)(_schedule_table[j] - now) > 0) continue; // scheduled for future... ignore for now

Loading…
Cancel
Save