* Fix IndexError instead of StopIteration when MessageIterator is done
* Make fill() return a boolean based on whether items were added to the
buffer, and update __next__() accordingly
Previously we used None as the sentinel for determining that a user had
not specified a default value for a field. This meant that a user could
never select `None` as the default value. We now properly use UNSET to
determine if a default was passed, this aligns better with the code as
it stands given that if no default is passed we'll use UNSET anyway.
* Check for Unset type in Emoji.custom
* Typecase id value to bool
in the case where id is Unset this will call the builtin
__bool__ which returns False. This is not ideal beacuse
an Id of 0 will mean the emoji is custom, but to fix would
require a deeper refactor of the Field logic. Lets put a pin
in it.
* Remove unused import
Previously to update a role you would update attributes of the role
object, and then call save. This was very much an anti-pattern when
compared to the way things work elsewhere, and had the following
annoyances attached to it;
- Updating attributes of the object actually smashes state, we aren't
guarenteed that the user will call save nor that the API will accept our
save, and thus attributes on the object (which could be shared within
the state module) are smashed and innaccurate.
- Guild.update_role is effectively useless in this case, we can only
ever pass a role object in. This makes partial updates impossible, and
forces us to match the OO interface to use it.
The new style follows along with how we do things elsewhere, there is
still likely some additional work that can be done here to allow passing
in the role, but for now we'll just call this a deprecation
andrei
Sebastian Winkler
Spencer
Moses Miller
Ahmed // Dropheart
Jari (LotU)
Kodie Goodwin
Anis B
Andrei Zbikowski
bunnyhero
Alex
ryan