From 4bab008f790256c41c762d73609078bc0a733dbd Mon Sep 17 00:00:00 2001 From: Andrei Date: Tue, 18 Apr 2017 07:37:11 -0700 Subject: [PATCH] Fix BufferedOpusEncoderPlayable cutting off playback too soon Previously the signal for when BufferedOpusEncoderPlayable was completed, was when the encoding process finished. However considering we buffer the encoding, this would cause the playable to complete 4096 frames before it was actually done. We now properly just enqueue a None (aka complete signal) when encoding is done, so that playback will complete fully. --- disco/voice/playable.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/disco/voice/playable.py b/disco/voice/playable.py index 98cbbc2..758b357 100644 --- a/disco/voice/playable.py +++ b/disco/voice/playable.py @@ -217,10 +217,9 @@ class BufferedOpusEncoderPlayable(BasePlayable, OpusEncoder, AbstractOpus): self.frames.put(self.encode(raw, self.samples_per_frame)) gevent.idle() self.source = None + self.frames.put(None) def next_frame(self): - if not self.source: - return None return self.frames.get()