LinuxGSM

6852 Commits

23 Branches

171 Tags

48 MiB

Tree: b983600c3b

Commit Graph

Author	SHA1	Message	Date
Daniel Gibbs	4067615be8	fix(ci): make Prettier workflow pass on develop (#4941 ) * style(alerts): prettier-format alert_matrix.sh Add the space in '2> /dev/null' that prettier-plugin-sh expects. This was in the original #4901 code and tripped the Prettier workflow on develop after merge (the workflow auto-formats and then can't push to the protected branch, so the run fails). * ci(prettier): ignore package-lock.json package-lock.json is machine-generated by npm; Prettier reformatting it conflicts with npm's own output and causes the Prettier auto-commit workflow to try (and fail) to push lockfile churn to protected develop. Ignoring it lets the workflow find nothing to change and pass.	1 month ago
Daniel Gibbs	641048dedb	feat(alerts): add Matrix alert provider (#4901 ) * feat(alerts): add Matrix alert provider * fix(alerts): use PUT instead of POST for Matrix send-event endpoint The Matrix Client-Server API requires PUT for /_matrix/client/v3/rooms/{roomId}/send/{eventType}/{txnId}; sending POST would be rejected by any spec-compliant homeserver (405), so alerts would never actually send. Also documents that matrixroom must be the internal room ID, not the human-readable room alias. * fix: restore executable bit on alert_matrix.sh * fix(alerts): register alert_matrix module and harden dispatch Addresses review feedback on the Matrix alert provider: - Register alert_matrix.sh in core_modules.sh so the module actually resolves when alert.sh calls it (without this the call fails as an unknown command and no alert is ever sent). - Use curl -sSL to follow redirects, matching the other alert modules (some homeservers/reverse proxies redirect the client API). - Require matrixhomeserver to be set in the dispatch condition, consistent with the TEST-ALERT checks, to avoid building a broken URL when it is empty.	1 month ago

Author

SHA1

Message

Date

Daniel Gibbs

4067615be8

fix(ci): make Prettier workflow pass on develop (#4941 )

* style(alerts): prettier-format alert_matrix.sh

Add the space in '2> /dev/null' that prettier-plugin-sh expects. This
was in the original #4901 code and tripped the Prettier workflow on
develop after merge (the workflow auto-formats and then can't push to
the protected branch, so the run fails).

* ci(prettier): ignore package-lock.json

package-lock.json is machine-generated by npm; Prettier reformatting it
conflicts with npm's own output and causes the Prettier auto-commit
workflow to try (and fail) to push lockfile churn to protected develop.
Ignoring it lets the workflow find nothing to change and pass.

1 month ago

Daniel Gibbs

641048dedb

feat(alerts): add Matrix alert provider (#4901 )

* feat(alerts): add Matrix alert provider

* fix(alerts): use PUT instead of POST for Matrix send-event endpoint

The Matrix Client-Server API requires PUT for
/_matrix/client/v3/rooms/{roomId}/send/{eventType}/{txnId}; sending
POST would be rejected by any spec-compliant homeserver (405), so
alerts would never actually send. Also documents that matrixroom
must be the internal room ID, not the human-readable room alias.

* fix: restore executable bit on alert_matrix.sh

* fix(alerts): register alert_matrix module and harden dispatch

Addresses review feedback on the Matrix alert provider:
- Register alert_matrix.sh in core_modules.sh so the module actually
  resolves when alert.sh calls it (without this the call fails as an
  unknown command and no alert is ever sent).
- Use curl -sSL to follow redirects, matching the other alert modules
  (some homeservers/reverse proxies redirect the client API).
- Require matrixhomeserver to be set in the dispatch condition,
  consistent with the TEST-ALERT checks, to avoid building a broken
  URL when it is empty.

1 month ago

2 Commits (b983600c3b014d2843abe93e618a1b52ac36aba0)