The code in `command_start.sh` and `command_stop.sh` has been refactored to simplify the checks for the start and stop commands. Instead of checking if `exitbypass` is empty, it now directly checks if `firstcommandname` matches specific values ("START", "RESTART" for start command, and "STOP" for stop command). This change improves readability and reduces unnecessary conditions.
- Renamed "${lockdir}/${selfname}-laststart.lock" to "${lockdir}/${selfname}-last-started.lock"
- Renamed "${lockdir}/backup.lock" to "${lockdir}/stopping.lock"
- Renamed "${lockdir}/${selfname}-start.lock" to "${lockdir}/${selfname}-started.lock"
- Renamed "${lockdir}/${selfname}-starting.lock" to "${lockdir}/${selfname}-stopping.lock"
This commit refactors the lockfile names in the codebase for better consistency and clarity. The changes make it easier to understand the purpose of each lockfile and improve readability.
The code changes in `command_start.sh` include adding an `exitbypass` flag to prevent lingering tmux sessions. This flag is used to stop the running server before creating a unique uid for the tmux socket name.
- Refactored the `fn_monitor_check_starting` function to check for stale lockfiles and print appropriate messages.
- Refactored the `fn_monitor_check_stopping` function to check for stale lockfiles and print appropriate messages.
- Removed redundant code that deletes the update lockfile in `command_update.sh` and `command_validate.sh`.
- Improved code readability by removing unnecessary comments.
- Changed the grep command to include the -a flag to handle non-text files
- Updated sed command to remove "modulefile=" from the output and redirect it to dev-debug-module-order.log
- Removed unnecessary function fn_start_jk2()
- Removed unused variable startparameters in fn_start_tmux()
- Added comments to clarify code functionality
- Renamed lockfile from "${lockdir}/${selfname}.lock" to "${lockdir}/${selfname}-start.lock"
- Updated log messages and log file names to include timestamp
- Updated the code to use the variable `socketname` instead of `sessionname` when interacting with tmux sessions.
- Added logic to create a unique socket name using a UID if it doesn't already exist.
- Refactored multiple functions (`fn_start_jk2`, `fn_start_tmux`, `fn_stop_graceful_ctrlc`, `fn_stop_graceful_cmd`, `fn_stop_graceful_goldsrc`, `fn_stop_graceful_avorion`, and `fn_stop_tmux`) to use the new socket name for tmux commands.
This commit improves the readability and maintainability of the code by separating the concept of session names from socket names, allowing for more flexibility in managing tmux sessions.
* fix(tmux): force tmux to create a new trmux server instance for each game instance to avoid sharing same pid.
* refactor: improve tmux command consistency and add session name flag
This commit refactors the code to improve consistency in the usage of the `tmux` command. It adds the `-L` flag followed by the session name to all `tmux` commands. This ensures that all commands are executed within the correct session. Additionally, it updates the `check_status.sh`, `command_console.sh`, `command_send.sh`, `command_start.sh`, `command_stop.sh`, and `info_distro.sh` files to include this change.
The changes ensure that all relevant commands are executed within the specified session, improving code readability and maintainability.
---------
Co-authored-by: cclecle <[email protected]>
Co-authored-by: Daniel Gibbs <[email protected]>
* feat: Added Option to prefix logs with timestamps
* feat: Added Option to prefix logs with timestamps
* Add parameters to every game
* feat: Switched timestamp enabling from True/False to on/off
* feat: Added quotes on variables
* add to new configs
* renamed to logtimestamp
* remove gawk as a requirement
gawk is a standard tool on linux distros and no check is required
* tidy
* rename to addtimestamp
---------
Co-authored-by: Reda.drissi.e <[email protected]>
Co-authored-by: Daniel Gibbs <[email protected]>
* add new details to queryraw
* fix httpport ac server
* correct info bug for bt1944server
* added bt1944 to info_parms
update info messages
bt1944ports
* steamport
* raw port
raw
* message display
* check_root bug
* add more ports
merge
words
* arma 3 improvements
* master port
* add arma3 ports
* portnames
* strip ./ from executable
* exec
* integrate ss
* replace netstat with ss
* port header
headerr
* remove inbound outbound
* ark
* shorten executable
* change to port display
* add info_distro
* response
* acserver improvements
acserver
ac
* add assettocorsa query
* ss
* rawport
* update av server exec
merge
av changes
* av ports
* av ss
bug
* av
* avserver
* remove port
* port changes
* listen
* col
* bt1944
* cmw
cmw
* cmw
* changes
* etl
* add servers
* hw
* inss
ins
* add rcon to insserver
* rcon
* jc
* jc3 minecraft
* mcb
* onset
* Memories of mars
* mumble
* changes
* steamport
* tcp query
* udp
* fix
* steamport
* info_distro now required before parms
* srcdslinuxopid
* srcds_linux
* hlds_linux
* ins
* date
* ns2
* rising world
rising world query port
rising world javaram
rising world
a
* rising world ports
* portipv6
* add ports to query raw
* add Rising World Query
* fix rising world game mode
* update 7 Days to Die
* port3
* increased sdtd glibc to 2.27
* corrected starbound ports location
* starbound
* added new SteamCMD error code
* Master server check if query raw
* Stationeers
* stationeers
* webadmin
* added extra query ports for ts3
a
* add teamspeak3 query
* add ts3 query details
* ts3 version
* queryport reverts back once gamedig finished
* added telnetport to ts3
* fix TS3 bug causing shutdown when starting debug
the fix was running and killing a running server
* show start parameters for ts3
* tower unite
* terraria
* terraria
* ss command in dev-query-raw
info_messages.sh
* ut4 and others
* more updates
* soldat
* col vint
* pvr query port
tab
* pvr query type tcp
* pvr gameport+400
* changed to shortname
* unreal99
* ut99 beacon
* httpport
* ut2k4
* kf
* kf
* bug
* httpport
* httpport
* more kf ports
* lan port
* steammasterport
* kf
* ports
* ports
* ut2k4
* ut2k4
* lanport
* lanport
* ro
* ro
* kf2
* httpport
* update naming
* ut3
* ut3
* ut3
* mom
* mom
* reshuffle
* sort list
* function re-shuffle
* merge info_parms and info_config into info_game.sh
a
* updated source filters
* added ac to edit ports array
* Revert "updated source filters"
This reverts commit e8621eaed6.
* spaces
* fix typo
* tidy
* re ordered ports edit array
* added java
* add bf1942
* Added Last Oasis
* corrected pc function name
* re ordered in alpha
* space
* remove space
#3239
Quoting the command and arguments causes tmux to treat it as a single command with spaces in it. Remove the quotes so tmux properly runs the command and passes arguments.
* remove remaining fn_parms
* remove ${parms}
* updated UI and comments
* add server date and other details improvements
* fix(post-details): prevent serverpassword showing in start parameters
* Fixed uniqueness constraint on session names by adding port to tmux sesssions. Removed content constraint from session name by avoiding grep regex
Co-authored-by: jason <[email protected]>
This update is a major refactor of how LinuxGSM updates itself.
* will now use a version tag if downloading module for the first time.
* added backup repo (Bitbucket) that will be used if Github is unavailable.
* added ./gameserver and module version comparison this will allow instances to be correctly updated if there is a version mismatch.
* UI changes when modules are fetched for the first time
* added sessionname to fix broken tmux session is ./gameserver is called ./gameserver.sh
* change apt to apt-get as recommended by the apt packages when dealing with scripts.
* Revert "fix(messages): fix some messages not using newline correctly (#2772)"
This reverts commit 3bd64bbc13.
* Revert "fix(messages): fix some messages not using newline correctly (#2765)"
This reverts commit c847ecb4b6.
* added new [ START ] message
* various messages improvements made
* add mumble query
* re-ordered serverlist.csv
* gamedig refactor
* query raw update
* gamedig: changed --query_port to --port
* add query data to log
* remove UDP query as does not work.
* refactor gamedig and gsquery
* add missing Factorio rcon port
* add fn_monitor_check_queryport
* add TCP query to Factorio
* add mta query support
* MTA IP address must be set. No longer using config
* remove mumble and ts3 from bypassing check_ip
* update netstat command for Project Zomboid
* adde query port to Project Zomboid
* update query mode for samp
* Update Teeworlds query
* add Soldat to TCP query
* update ss3 port info
* add query details to Serious Sam 3
* add Terraria query port
* ts3 now uses tcp query as proper query requires permissions changes
* update ut99 query
* gsquery add gamespy1
* separate out unreal engine functions
* updated ut2k4 query
* update Teeworlds query
* update Factorio query
* change engine if to shortname
Daniel Gibbs
ChaCha
Reda DRISSI
Christian
Nick Mayer