From fdae2a15e62c4bfc6b6610caaf64f70daf480b63 Mon Sep 17 00:00:00 2001
From: Daniel Gibbs <me@danielgibbs.co.uk>
Date: Sat, 2 Sep 2017 23:46:22 +0100
Subject: [PATCH] code tidy

---
 lgsm/functions/alert.sh               |  4 +++-
 lgsm/functions/command_postdetails.sh | 10 ++--------
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/lgsm/functions/alert.sh b/lgsm/functions/alert.sh
index 067687176..1d973153a 100644
--- a/lgsm/functions/alert.sh
+++ b/lgsm/functions/alert.sh
@@ -87,7 +87,9 @@ fi
 
 # Generate alert log
 fn_alert_log
-alert=1
+
+# Generates the more info link
+alertflag=1
 command_postdetails.sh
 
 if [ "${discordalert}" == "on" ]&&[ -n "${discordalert}" ]; then
diff --git a/lgsm/functions/command_postdetails.sh b/lgsm/functions/command_postdetails.sh
index bf8c7a334..f94fb11b8 100644
--- a/lgsm/functions/command_postdetails.sh
+++ b/lgsm/functions/command_postdetails.sh
@@ -34,12 +34,6 @@ posttarget=${posttarget="https://hastebin.com"}
 # This, too, may be overridden from the command line at the top-level
 postexpire="${postexpire="30D"}"
 
-# This file sources the info_messages.sh file to leverage all
-# of the already-defined functions. To keep the command_details.sh
-# from actually producing output, the main executable statements have
-# been wrapped in the equivalent of an ifdef clause, that looks
-# for the variable "postdetails" to be defined. -CedarLUG
-
 # source all of the functions defined in the details command
 info_messages.sh
 
@@ -49,7 +43,7 @@ fn_bad_postdetailsfile() {
 }
 
 # Rather than a one-pass sed parser, default to using a temporary directory
-if [ -n "${alert}" ]; then
+if [ -n "${alertflag}" ]; then
 	postdetailsfile="${alertlog}"
 else
 	postdetailsfile="${tmpdir}/postdetails-$(date +"%Y-%d-%m_%H-%M-%S").tmp"
@@ -117,7 +111,7 @@ fi
 # cleanup
 rm "${postdetailsfile}" || /bin/true
 
-if [ -z "${alert}" ]; then
+if [ -z "${alertflag}" ]; then
 	core_exit.sh
 else
 	alerturl="${pdurl}"