Browse Source

fix(check_deps): avoid false Debian version check on Ubuntu

Ubuntu reports ID_LIKE=debian, which caused Debian upper-version checks to
run on Ubuntu and incorrectly fail legacy titles on Ubuntu 22.04.x.

Use distroid==debian for Debian limits in legacy compatibility guards so:
- bf1942/bfv pass on Ubuntu 22.04.x as intended
- btl/onset limits still apply correctly
- Debian limits still apply on Debian only
pull/4903/head
Daniel Gibbs 1 month ago
parent
commit
42f2f53cd5
  1. 6
      lgsm/modules/check_deps.sh

6
lgsm/modules/check_deps.sh

@ -362,7 +362,7 @@ if [ -n "${distrosupport}" ]; then
fi
# These titles are only supported up to Ubuntu 22.04 (Jammy) and Debian 12 (Bookworm).
if { [ "${distroid}" == "ubuntu" ] && dpkg --compare-versions "${distroversion}" "gt" "22.04"; } || { [ "${distroidlike}" == "debian" ] && dpkg --compare-versions "${distroversion}" "gt" "12"; }; then
if { [ "${distroid}" == "ubuntu" ] && dpkg --compare-versions "${distroversion}" "gt" "22.04"; } || { [ "${distroid}" == "debian" ] && dpkg --compare-versions "${distroversion}" "gt" "12"; }; then
if [ "${shortname}" == "bf1942" ] || [ "${shortname}" == "bfv" ]; then
fn_print_failure_nl "${gamename} is not supported on ${distroname} (requires Ubuntu <= 22.04 or Debian <= 12)."
fn_script_log_fail "${gamename} is not supported on ${distroname}."
@ -370,8 +370,8 @@ if { [ "${distroid}" == "ubuntu" ] && dpkg --compare-versions "${distroversion}"
fi
fi
# These titles are only supported up to Ubuntu 20.04 and Debian 11 (and Debian-like derivatives).
if { [ "${distroid}" == "ubuntu" ] && dpkg --compare-versions "${distroversion}" "gt" "20.04"; } || { [ "${distroidlike}" == "debian" ] && dpkg --compare-versions "${distroversion}" "gt" "11"; }; then
# These titles are only supported up to Ubuntu 20.04 and Debian 11.
if { [ "${distroid}" == "ubuntu" ] && dpkg --compare-versions "${distroversion}" "gt" "20.04"; } || { [ "${distroid}" == "debian" ] && dpkg --compare-versions "${distroversion}" "gt" "11"; }; then
if [ "${shortname}" == "onset" ] || [ "${shortname}" == "btl" ]; then
fn_print_failure_nl "${gamename} is not supported on ${distroname} (requires Ubuntu <= 20.04 or Debian <= 11)."
fn_script_log_fail "${gamename} is not supported on ${distroname}."

Loading…
Cancel
Save